New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Do not display technical error messages #156

Merged
merged 4 commits into from Sep 14, 2016

Conversation

Projects
None yet
3 participants
@LukasReschke
Member

LukasReschke commented Sep 14, 2016

Backport of #154

No backport to older versions required.

cc @MorrisJobke @oparoz Please review.

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Sep 14, 2016

Member

I assume createMock was introduced in NC11?

Member

oparoz commented Sep 14, 2016

I assume createMock was introduced in NC11?

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 14, 2016

Member

I assume createMock was introduced in NC11?

It's in phpunit 5.x and we added a backport for phpunit 4.8: https://github.com/nextcloud/server/pull/1396/files#diff-c24f6db53e742461694bff7f95900daa

Member

MorrisJobke commented Sep 14, 2016

I assume createMock was introduced in NC11?

It's in phpunit 5.x and we added a backport for phpunit 4.8: https://github.com/nextcloud/server/pull/1396/files#diff-c24f6db53e742461694bff7f95900daa

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 14, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Sep 14, 2016

Tested and works 👍

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Sep 14, 2016

Member

It's in phpunit 5.x and we added a backport for phpunit 4.8: https://github.com/nextcloud/server/pull/1396/files#diff-c24f6db53e742461694bff7f95900daa

OK, but it doesn't seem to be working properly. Any idea why?

Member

oparoz commented Sep 14, 2016

It's in phpunit 5.x and we added a backport for phpunit 4.8: https://github.com/nextcloud/server/pull/1396/files#diff-c24f6db53e742461694bff7f95900daa

OK, but it doesn't seem to be working properly. Any idea why?

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 14, 2016

Member

OK, but it doesn't seem to be working properly. Any idea why?

I fixed the ::class stuff that is 5.6+ only

Member

MorrisJobke commented Sep 14, 2016

OK, but it doesn't seem to be working properly. Any idea why?

I fixed the ::class stuff that is 5.6+ only

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Sep 14, 2016

Member

I fixed the ::class stuff that is 5.6+ only

Thanks :)

Member

oparoz commented Sep 14, 2016

I fixed the ::class stuff that is 5.6+ only

Thanks :)

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 14, 2016

Member

And I now also added the wrapper. This was not backported to stable10.

Member

MorrisJobke commented Sep 14, 2016

And I now also added the wrapper. This was not backported to stable10.

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Sep 14, 2016

Member

And I now also added the wrapper. This was not backported to stable10.

Ah ha! Mystery solved! Thanks @MorrisJobke :)

Member

oparoz commented Sep 14, 2016

And I now also added the wrapper. This was not backported to stable10.

Ah ha! Mystery solved! Thanks @MorrisJobke :)

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Sep 14, 2016

Member

Don't merge right away as I'm going to move that method to a parent class to make it available to other tests in case we need to use it again somewhere else.

Member

oparoz commented Sep 14, 2016

Don't merge right away as I'm going to move that method to a parent class to make it available to other tests in case we need to use it again somewhere else.

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Sep 14, 2016

Member

👍

@oparoz Is this okay to merge once CI is fine?

Member

MorrisJobke commented Sep 14, 2016

👍

@oparoz Is this okay to merge once CI is fine?

@oparoz

This comment has been minimized.

Show comment
Hide comment
@oparoz

oparoz Sep 14, 2016

Member

Yes!

Member

oparoz commented Sep 14, 2016

Yes!

@MorrisJobke MorrisJobke merged commit 88a89ae into stable10 Sep 14, 2016

1 of 2 checks passed

Scrutinizer Created
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the stable10-error-messages branch Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment