Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

[stable13] Fix share drop down in gallery not properly shown #394

Conversation

danxuliu
Copy link
Member

Backport of #393

The share drop down was appended to the grandparent element of the
clicked element that caused the drop down to be shown. This, in itself,
was not problematic; however, due to the CSS rules for the actions bar
when the drop down was a child of the action bar (that is, when shown in
the gallery) it was not properly shown. Now the drop down is appended to
either the "#slideshow" element (when in the slideshow, just like
before) or to the "#controls" element (when in the gallery, the parent
of the actions bar).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The social sharing menu shown in the share drop down was off by a few
pixels both in the gallery and in the slideshow; to fix this, different
values had to be used in each case due to slight style differences in
the share drop down depending on its ancestors.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added bug Something isn't working design Related to the design 3. to review Waiting for reviews labels Feb 12, 2018
@danxuliu danxuliu added this to the Nextcloud 13.0.1 milestone Feb 12, 2018
@codecov
Copy link

codecov bot commented Feb 12, 2018

Codecov Report

Merging #394 into stable13 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable13     #394   +/-   ##
===========================================
  Coverage       82.27%   82.27%           
  Complexity        335      335           
===========================================
  Files              38       38           
  Lines            1286     1286           
===========================================
  Hits             1058     1058           
  Misses            228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec43c0...a860f6e. Read the comment docs.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 2888545 into stable13 Feb 20, 2018
@MorrisJobke MorrisJobke deleted the stable13-393-fix-share-drop-down-in-gallery-not-properly-shown branch February 20, 2018 11:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3. to review Waiting for reviews bug Something isn't working design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants