New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix share drop down in gallery not properly shown #394

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Projects
None yet
2 participants
@danxuliu
Member

danxuliu commented Feb 12, 2018

Backport of #393

danxuliu added some commits Feb 11, 2018

Fix element to append the share drop down to
The share drop down was appended to the grandparent element of the
clicked element that caused the drop down to be shown. This, in itself,
was not problematic; however, due to the CSS rules for the actions bar
when the drop down was a child of the action bar (that is, when shown in
the gallery) it was not properly shown. Now the drop down is appended to
either the "#slideshow" element (when in the slideshow, just like
before) or to the "#controls" element (when in the gallery, the parent
of the actions bar).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Fix social sharing menu position
The social sharing menu shown in the share drop down was off by a few
pixels both in the gallery and in the slideshow; to fix this, different
values had to be used in each case due to slight style differences in
the share drop down depending on its ancestors.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@danxuliu danxuliu added this to the Nextcloud 13.0.1 milestone Feb 12, 2018

@danxuliu danxuliu requested review from MorrisJobke and oparoz Feb 12, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 12, 2018

Codecov Report

Merging #394 into stable13 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable13     #394   +/-   ##
===========================================
  Coverage       82.27%   82.27%           
  Complexity        335      335           
===========================================
  Files              38       38           
  Lines            1286     1286           
===========================================
  Hits             1058     1058           
  Misses            228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec43c0...a860f6e. Read the comment docs.

@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 2888545 into stable13 Feb 20, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 5ec43c0...a860f6e
Details
codecov/project 82.27% remains the same compared to 5ec43c0
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the stable13-393-fix-share-drop-down-in-gallery-not-properly-shown branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment