New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix gallery button hidden in folders without create permission #402

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Mar 1, 2018

Backport of #401

Fix gallery button hidden in folders without create permission
In the "Files" app the actions that require the create permission (those
marked as "creatable") are hidden in folders that do not have that
permission. However, as there is only one ".actions" element inside
"#controls" and that ".actions" element also has the "creatable" CSS
class appending the gallery button to it meant that the gallery button
was hidden in folders without create permissions. Now the gallery button
is appended to the "#controls" element instead, and thus it is no longer
affected by the permissions of the folder.

As the button is now appended to the "#controls" element its top margin
was increased to align it with the rest of the buttons (as the
".actions" element uses a padding of 5px), and as the button appears in
the top right corner of the contents its right margin was set to the
same value as the top margin to "frame" the button.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@danxuliu danxuliu added this to the Nextcloud 13.0.1 milestone Mar 1, 2018

@danxuliu danxuliu requested review from rullzer, MorrisJobke and skjnldsv Mar 1, 2018

@codecov

This comment has been minimized.

codecov bot commented Mar 1, 2018

Codecov Report

Merging #402 into stable13 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable13     #402   +/-   ##
===========================================
  Coverage       82.27%   82.27%           
  Complexity        335      335           
===========================================
  Files              38       38           
  Lines            1286     1286           
===========================================
  Hits             1058     1058           
  Misses            228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c88f70...3c67d89. Read the comment docs.

@rullzer rullzer merged commit afa9d0e into stable13 Mar 1, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 5c88f70...3c67d89
Details
codecov/project 82.27% remains the same compared to 5c88f70
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the stable13-401-fix-gallery-button-hidden-in-folders-without-create-permission branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment