New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Removed old code already present thanks to the files app #406

Merged
merged 3 commits into from Mar 9, 2018

Conversation

@skjnldsv
Member

skjnldsv commented Mar 9, 2018

Backport : Removed old code already present thanks to the files app #399

skjnldsv added some commits Oct 26, 2017

Removed old code already present thanks to the files app
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Popover menu delete button padding fix on files
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

@skjnldsv skjnldsv added this to the Nextcloud 13.0.1 milestone Mar 9, 2018

@skjnldsv skjnldsv self-assigned this Mar 9, 2018

@skjnldsv skjnldsv added the design label Mar 9, 2018

@MorrisJobke MorrisJobke referenced this pull request Mar 9, 2018

Merged

13.0.1 RC1 #8748

10 of 10 tasks complete
@@ -102,7 +69,7 @@ a.showCruds {
opacity:.5;
}
a.unshare {
.shareWithList > li > a.unshare {

This comment has been minimized.

@MorrisJobke

MorrisJobke Mar 9, 2018

Member

This is an ID instead of a class in my setup somehow 🤔

This comment has been minimized.

This comment has been minimized.

@MorrisJobke

MorrisJobke Mar 9, 2018

Member

Changing it to #shareWithList:

Before:

bildschirmfoto 2018-03-09 um 11 52 15

After:

bildschirmfoto 2018-03-09 um 11 52 47

@codecov

This comment has been minimized.

codecov bot commented Mar 9, 2018

Codecov Report

Merging #406 into stable13 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable13     #406   +/-   ##
===========================================
  Coverage       82.27%   82.27%           
  Complexity        335      335           
===========================================
  Files              38       38           
  Lines            1286     1286           
===========================================
  Hits             1058     1058           
  Misses            228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a21cc6...041cb3d. Read the comment docs.

Fixed sharedwithlist selector
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@MorrisJobke

Tested and works 👍

@MorrisJobke MorrisJobke merged commit ec70804 into stable13 Mar 9, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 8a21cc6...041cb3d
Details
codecov/project 82.27% remains the same compared to 8a21cc6
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the backport-clean-old-code branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment