New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix "No results found" tooltip #419

Merged
merged 2 commits into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Mar 23, 2018

Backport of #415

danxuliu added some commits Mar 22, 2018

Fix reference error
There is no "view" nor "configModel" in a Share of the gallery;
configuration parameters are got using "oc_appconfig".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Hide tooltip when the input field is cleared
The "No results found" tooltip is now removed when the input field is
cleared.

This unifies its behaviour with the one used in the server, but it does
not address its problems (for example, if a search is started and while
it is being performed the input field is cleared the tooltip would be
still shown once the search response is received, even if the input
field is now empty).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Mar 23, 2018

Codecov Report

Merging #419 into stable13 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable13     #419   +/-   ##
===========================================
  Coverage       82.27%   82.27%           
  Complexity        335      335           
===========================================
  Files              38       38           
  Lines            1286     1286           
===========================================
  Hits             1058     1058           
  Misses            228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a3d0e...d010adb. Read the comment docs.

@MorrisJobke MorrisJobke merged commit d5b7e67 into stable13 Mar 23, 2018

5 checks passed

codecov/patch Coverage not affected when comparing e2a3d0e...d010adb
Details
codecov/project 82.27% remains the same compared to e2a3d0e
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the stable13-415-fix-no-results-found-tooltip branch Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment