New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Hide "No results found" tooltip on autocompletion #424

Merged
merged 1 commit into from Apr 4, 2018

Conversation

Projects
None yet
3 participants
@danxuliu
Member

danxuliu commented Apr 3, 2018

Backport of #421

Hide "No results found" tooltip on autocompletion
If the tooltip is not explicitly hidden it would still be shown once the
autocompletion dropdown is shown (behind it while it is open, but fully
visible when it is closed).

This unifies its behaviour with the one used in the server, but it does
not address its problems (for example, if a search is started and while
it is being performed the input field is cleared the tooltip would be
still shown once the search response is received, even if the input
field is now empty).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Apr 3, 2018

Codecov Report

Merging #424 into stable13 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable13     #424   +/-   ##
===========================================
  Coverage       82.27%   82.27%           
  Complexity        335      335           
===========================================
  Files              38       38           
  Lines            1286     1286           
===========================================
  Hits             1058     1058           
  Misses            228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cdf317...e759221. Read the comment docs.

@MorrisJobke MorrisJobke merged commit 1c37975 into stable13 Apr 4, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 9cdf317...e759221
Details
codecov/project 82.27% remains the same compared to 9cdf317
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MorrisJobke MorrisJobke deleted the stable13-421-hide-no-results-found-tooltip-on-autocompletion branch Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment