New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix error while clicking on the share link checkbox #430

Merged
merged 3 commits into from Apr 12, 2018

Conversation

Projects
None yet
2 participants
@xh3n1
Member

xh3n1 commented Apr 12, 2018

Backport of #428

xh3n1 added some commits Apr 12, 2018

use data function instead of attr function
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
(cherry picked from commit 7089a58)
ensure that data-id is removed when unsharing
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
(cherry picked from commit d25049d)

@xh3n1 xh3n1 requested review from daniellandau, oparoz, MorrisJobke and danxuliu and removed request for daniellandau Apr 12, 2018

@danxuliu danxuliu added this to the Nextcloud 13.0.2 milestone Apr 12, 2018

Add auth token to GitHub requests
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Apr 12, 2018

Codecov Report

Merging #430 into stable13 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable13     #430   +/-   ##
===========================================
  Coverage       82.27%   82.27%           
  Complexity        335      335           
===========================================
  Files              38       38           
  Lines            1286     1286           
===========================================
  Hits             1058     1058           
  Misses            228      228

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55200ca...df535c8. Read the comment docs.

@danxuliu

Tested and works 👍

I have included too the fix for the GitHub token failure in Drone for the stable13 branch.

@danxuliu danxuliu merged commit 4a5ebb4 into stable13 Apr 12, 2018

2 checks passed

continuous-integration/drone/pr the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danxuliu danxuliu deleted the backport-data-fix branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment