New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEIC/HEIF support to the gallery #464

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
3 participants
@steiny2k
Copy link
Contributor

steiny2k commented Aug 27, 2018

Requires:

Fixes: owncloud/gallery#737

Licence: AGPL

Description

This is just adding the mime type for apple iPhone HEIC files to the $baseMimeTypes

Features

  • renders HEIC files as thumbnails and in the slideshow

Screenshots or screencasts

Caveats

  • needs nextcloud 14

Tests

Test plan

  • Upload a test image
  • Make sure it gets rendered as a thumbnail in gallery
  • Make sure it gets rendered in slideshow
  • Make sure it can be downloaded from slideshow

Tested on

  • macOS / Firefox
  • macOS / Safari

TODO

  • Other test-cases (?)

Check list

  • Code is properly documented
  • Code is properly formatted
  • Commits have been squashed
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Reviewers

@MorrisJobke
@rullzer
@oparoz

[14.0] Add HEIC/HEIF support to the gallery. Requires
nextcloud/server#10827

Signed-off-by: Sebastian Steinmetz <me@sebastiansteinmetz.ch>

@steiny2k steiny2k requested a review from oparoz Aug 27, 2018

@steiny2k

This comment has been minimized.

Copy link
Contributor

steiny2k commented Aug 27, 2018

Hi, the CI tests fail. I'm wondering whether that's due to my changes, or whether that's a known issue with the tests at the moment. As the change is really tiny, I can't believe it's due to that...

@MorrisJobke MorrisJobke added this to the Nextcloud 14.0.1 milestone Aug 31, 2018

@blizzz blizzz modified the milestones: Nextcloud 14.0.1, Nextcloud 15 Sep 19, 2018

@blizzz blizzz changed the title [14.0] Add HEIC/HEIF support to the gallery Add HEIC/HEIF support to the gallery Sep 19, 2018

@blizzz

This comment has been minimized.

Copy link
Member

blizzz commented Sep 19, 2018

set the milestone to 15 as it is against master.

tests in gallery are broken anyway, there's another ticket about it 🙊

@MorrisJobke MorrisJobke merged commit e84fdf0 into nextcloud:master Oct 3, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer No new issues
Details
continuous-integration/drone/pr the build was successful
Details

@steiny2k steiny2k deleted the steiny2k:HEICHEIF branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment