Crashes Nextcloud 17 beta

[editedweb]

As soon as the app is enabled on Nextcloud 17, the browser throws a 500 error. Deleting the app folder allows Nextcloud to work again.

[cellisten]

I can confirm. Same issue here.
Error message:
pHP Fatal error: Declaration of OCA\GroupFolders\Versions\VersionsBackend::getVersionFile(OCP\IUser $user, OCP\Files\FileInfo $sourceFile, int $revision): OCP\Files\File must be compatible with OCA\Files_Versions\Versions\IVersionBackend::getVersionFile(OCP\IUser $user, OCP\Files\FileInfo $sourceFile, $revision): OCP\Files\File in /var/www/html/apps/groupfolders/lib/Versions/VersionsBackend.php on line 38

[editedweb]

Thanks cellisten, I hadn't had the chance to dig through the error log yet :) But yes, I just checked, it's the same error :)

[pixelipo]

I've found the culprit - there's a method in that class that was incompatible with a parent method. I've removed int manually on my local setup and it works as expected.

However, it seems like this has already been fixed in commit fa87c71 but a version with that code hasn't been released yet. @icewind1991 @juliushaertl any ETA for new release of Group Folders app?

I guess this issue can be closed or do you prefer to keep open until patch is released?

[oneilonline]

Any update to this? Our nextcloud is dead in the water without this working. None of the syncs can occur and no one can access files/folders. Thank you
...I went ahead and made the changes/updates as posted above to get us working again. @pixelipo Thank you

[wiswedel]

@oneilonline Just a side note: I hope you're not running a productive instance on a Beta, are you?

[oneilonline]

@oneilonline Just a side note: I hope you're not running a productive instance on a Beta, are you?

No.

[wiswedel]

CC @icewind1991 @juliushaertl

[juliushaertl]

There is no 17 compatible release yet. See #572 for the progress

[tacruc]

Connected to this issue, this app enabled on an 16 version will break the update process to nextcloud 17 beta 3. You click on update in the settings, which works, but the redirect will not lead to

but end up on a gray screen. Digging in the logs showed the error above. After disabling the app with occ I cloud continue with the update.

[ghost]

Connected to this issue, this app enabled on an 16 version will break the update process to nextcloud 17 beta 3. You click on update in the settings, which works, but the redirect will not lead to

but end up on a gray screen. Digging in the logs showed the error above. After disabling the app with occ I cloud continue with the update.

I can confirm this on updating from 16.04 to 17.0 beta3 with activated groupfolder 4.1

[wiswedel]

@tacruc @Lars1963 Please see @juliushaertl 's comment above:

There is no 17 compatible release yet. See #572 for the progress

[tacruc]

Still an incompatible app should be disabled by the updater and not crash the update process, or?

[wiswedel]

Still an incompatible app should be disabled by the updater and not crash the update process, or?

Fair enough...CC @juliushaertl

[editedweb]

Yes, that's why I posted the original bug.
Following the workaround shared by pixelipo fa87c71 has worked, and seems to work on beta 3 as well.
I haven't found any other compatibility issues since making those minor changes.

[juliushaertl]

Still an incompatible app should be disabled by the updater and not crash the update process, or?
Fair enough...CC @juliushaertl

Not sure what happened there, there is no 17 compatible release for groupfolders. Maybe the related class gets loaded to early so the disabling is never triggered

[ghost]

Still an incompatible app should be disabled by the updater and not crash the update process, or?
Fair enough...CC @juliushaertl

Not sure what happened there, there is no 17 compatible release for groupfolders. Maybe the related >class gets loaded to early so the disabling is never triggered

As I tried again with disabled and removed groupfolders prior to updating, the updateprocess was smoothly as ever. Other incompatible apps were correctly disabled during the updating. So it seems to be a groupfolder-problem.

[juliushaertl]

I just have checked my update log from 16.0.3 to 17.0.0.2 and for me groupfolders has been disabled just fine:

{"reqId":"FUAGgFIzU5f9ucgm62hP","level":1,"time":"2019-08-20T09:17:59+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Updater::incompatibleAppDisabled: Disabled incompatible app: groupfolders","userAgent":"--","version":"16.0.3.0"}

Any change you could check your logs if that also happened for you?

[ghost]

I just have checked my update log from 16.0.3 to 17.0.0.2 and for me groupfolders has been disabled just fine:

{"reqId":"FUAGgFIzU5f9ucgm62hP","level":1,"time":"2019-08-20T09:17:59+00:00","remoteAddr":"","user":"--","app":"updater","method":"","url":"--","message":"\\OC\\Updater::incompatibleAppDisabled: Disabled incompatible app: groupfolders","userAgent":"--","version":"16.0.3.0"}

Any change you could check your logs if that also happened for you?

I did a complete server-reset, so the logs are not there anymore. 😭 I just noticed, you used beta 2. So maybe a specific beta 3 problem? @tacruc also confirmed with beta 3.

[tacruc]

Just checkt the log.

[PHP] Error: Declaration of OCA\GroupFolders\Versions\VersionsBackend::getVersionFile(OCP\IUser $user, OCP\Files\FileInfo $sourceFile, int $revision): OCP\Files\File must be compatible with OCA\Files_Versions\Versions\IVersionBackend::getVersionFile(OCP\IUser $user, OCP\Files\FileInfo $sourceFile, $revision): OCP\Files\File at /srv/www/nextcloud/apps/groupfolders/lib/Versions/VersionsBackend.php#38

GET /
from 138.232.236.7 at 2019-08-29T15:42:39+02:00

Disabling the app
2019-08-29 15:51:15 sudo -u wwwrun php7 occ app:disable groupfolders
and I managed to start the updater at

[updater] Info: \OC\Updater::maintenanceEnabled: Turned on maintenance mode

GET /core/ajax/update.php?requesttoken=cofjNHs%2Be%2FqB337pv56PUEpddlmKd1uu3Uho0D4mOvU%3D%3ACOioGyxRGpvImy7Q3vngAxAHBxe9Ij%2FirzJZlWoVDa0%3D
from 138.232.236.7 at 2019-08-29T15:53:26+02:00

So the error occurs after one clicks on update in the admin setting page and before one could start the updater in the web interface.

[juliushaertl]

5.0.0 has been release for the upcoming Nextcloud 17

[Terrox]

I just had a white screen of death after upgrade from Nextcloud 16 to 17.0.1 before the Apps upgrade step. I removed the /app/groupfolders/ to continue after randomly finding this post matching some log errors. So this is a critical bug for upgraders.

[fsteinbauer]

I also got this error on a production version.

PHP Fatal error: Declaration of OCA\\GroupFolders\\Versions\\VersionsBackend::getVersionFile(OCP\\IUser $user, OCP\\Files\\FileInfo $sourceFile, int $revision): OCP\\Files\\File must be compatible with OCA\\Files_Versions\\Versions\\IVersionBackend::getVersionFile(OCP\\IUser $user, OCP\\Files\\FileInfo $sourceFile, $revision)

How can I restore the nextcloud instance?

[fsteinbauer]

To anyone having the same issue while updating from 16.0.5 to 17.0.1:
Disable the groupfolder extension using the cli:
runuser --user www-data -- php occ app:disable groupfolders

Then go back to the web page, finish the update.
Go to Settings >> Apps und update Groupfolders to 5.0.4.
Enable Groupfolders again.
Voilá

[despens]

I used the web updater from 16.0.7 to 17.0.2 and got the same error with groupfolders. The web updater noted that all apps would have updates available with the new version.