Skip to content
This repository was archived by the owner on Aug 3, 2022. It is now read-only.

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 28, 2017

follow up of #9 and #10 since those pr where based on the wrong branch.

  • Fix aspect ratio of the provider logo
  • Build without APPLICATION_PROVIDERS set if failing

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@jancborchardt
Copy link
Member

jancborchardt commented Aug 28, 2017

@juliushaertl btw just one thing I think I didn’t mention so far: The logo of the provider should never be stretched (in the example images it was). It should only use up the maximum height or width (whatever comes first) while preserving aspect ratio, and we should use the recommended size we use on the website.

@juliusknorr
Copy link
Member Author

@jancborchardt I'll check that again.

@juliusknorr juliusknorr closed this Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants