This repository has been archived by the owner. It is now read-only.

Add list of providers to setup wizard #9

Closed
wants to merge 8 commits into
base: master-upstream
from

Conversation

Projects
None yet
3 participants
@juliushaertl
Member

juliushaertl commented Jun 13, 2017

ToDo:

  • Filter list by free accounts/country

2017-06-13-151258_750x507_scrot
2017-06-13-151325_750x507_scrot

@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Jun 28, 2017

Member
  • Remove owncloudprovidermodel (leftover from trying to use qlistview)
  • Don't build with provider list when PROVIDER_LIST is not defined
Member

juliushaertl commented Jun 28, 2017

  • Remove owncloudprovidermodel (leftover from trying to use qlistview)
  • Don't build with provider list when PROVIDER_LIST is not defined

juliushaertl added some commits Jun 6, 2017

Add provider list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Resize list items height and load images from json
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Filter provider list by free plans or country
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Make building optional
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Disable by default
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Use model class for providers
Signed-off-by: Julius Härtl <jus@bitgrid.net>

@juliushaertl juliushaertl referenced this pull request Jul 11, 2017

Closed

Implement account registration in the wizard #10

0 of 3 tasks complete

@juliushaertl juliushaertl requested a review from rullzer Jul 11, 2017

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Jul 22, 2017

Member

@jancborchardt is this looking good for you?

Member

rullzer commented Jul 22, 2017

@jancborchardt is this looking good for you?

@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Jul 24, 2017

Member

Some more things that came up in a call with @jospoortvliet

  • Free plans should be shown by default
  • Show providers for the current users country first
Member

juliushaertl commented Jul 24, 2017

Some more things that came up in a call with @jospoortvliet

  • Free plans should be shown by default
  • Show providers for the current users country first
@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Aug 2, 2017

Member

Very nice already! Just some things:

  • The two buttons currently almost look like they belong to the server address input field. They should have a header on top of them saying: "Don't have a Nextcloud server yet?" and also move a bit closer together.

  • What's that "all" dropdown on the top right?

  • is it possible to put the "Free plans" checkbox and "All" dropdown in the bottom row where Back and Next are to save space?

  • I'd say we simply show free plans by default too, and add a badge if a provider has them. Trying out stuff for free is an important step for any user. :) (we don't even need that checkbox)

Member

jancborchardt commented Aug 2, 2017

Very nice already! Just some things:

  • The two buttons currently almost look like they belong to the server address input field. They should have a header on top of them saying: "Don't have a Nextcloud server yet?" and also move a bit closer together.

  • What's that "all" dropdown on the top right?

  • is it possible to put the "Free plans" checkbox and "All" dropdown in the bottom row where Back and Next are to save space?

  • I'd say we simply show free plans by default too, and add a badge if a provider has them. Trying out stuff for free is an important step for any user. :) (we don't even need that checkbox)

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Aug 2, 2017

Member

The goal basically is through filtering, geolocation and prioritization to have 3 great choices directly in there. People should not need to scroll and search for long. :)

Member

jancborchardt commented Aug 2, 2017

The goal basically is through filtering, geolocation and prioritization to have 3 great choices directly in there. People should not need to scroll and search for long. :)

@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Aug 4, 2017

Member

The goal basically is through filtering, geolocation and prioritization to have 3 great choices directly in there. People should not need to scroll and search for long. :)

I guess we should just show the providers for the current users location, so the "All" dropdown will show the users country by default.

Member

juliushaertl commented Aug 4, 2017

The goal basically is through filtering, geolocation and prioritization to have 3 great choices directly in there. People should not need to scroll and search for long. :)

I guess we should just show the providers for the current users location, so the "All" dropdown will show the users country by default.

Use proper defaults for showing provider list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Aug 6, 2017

Member

@jancborchardt I addressed your comments.

It now shows the providers of the users country, free only on startup.
2017-08-06-093438_750x531_scrot
2017-08-06-104903_750x531_scrot

is it possible to put the "Free plans" checkbox and "All" dropdown in the bottom row where Back and Next are to save space?

I'm not aware of any possibility to do that. Maybe @rullzer has an idea, but to me it seems like the QWizard is limited to adding buttons on the bottom row.

The goal basically is through filtering, geolocation and prioritization to have 3 great choices directly in there. People should not need to scroll and search for long. :)

Should we introduce some flag like "featured" provider so they show up on top of the list? I remember there has been some discussion about that somewhere, but that was quite a controversial topic iirc. cc @jospoortvliet

Member

juliushaertl commented Aug 6, 2017

@jancborchardt I addressed your comments.

It now shows the providers of the users country, free only on startup.
2017-08-06-093438_750x531_scrot
2017-08-06-104903_750x531_scrot

is it possible to put the "Free plans" checkbox and "All" dropdown in the bottom row where Back and Next are to save space?

I'm not aware of any possibility to do that. Maybe @rullzer has an idea, but to me it seems like the QWizard is limited to adding buttons on the bottom row.

The goal basically is through filtering, geolocation and prioritization to have 3 great choices directly in there. People should not need to scroll and search for long. :)

Should we introduce some flag like "featured" provider so they show up on top of the list? I remember there has been some discussion about that somewhere, but that was quite a controversial topic iirc. cc @jospoortvliet

Unify button layout in provider list
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Aug 6, 2017

Member

Nice! Only a few details I'd change:

  • Instead of "Search for a hosting provider" call the button "Choose a provider"
  • The list would look nicer & more modern without the alternating white-grey background. A little more vertical whitespace would probably be enough.
  • The "Free" tag can be a bit more explainable saying "Offers free plans" and be below the "more info"/"Register" button
  • Is it possible to remove the whitespace under the scrollable container between the horizontal line? Or also remove the horizontal line?
Member

jancborchardt commented Aug 6, 2017

Nice! Only a few details I'd change:

  • Instead of "Search for a hosting provider" call the button "Choose a provider"
  • The list would look nicer & more modern without the alternating white-grey background. A little more vertical whitespace would probably be enough.
  • The "Free" tag can be a bit more explainable saying "Offers free plans" and be below the "more info"/"Register" button
  • Is it possible to remove the whitespace under the scrollable container between the horizontal line? Or also remove the horizontal line?
@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Aug 8, 2017

Member

@juliushaertl @jancborchardt

is it possible to put the "Free plans" checkbox and "All" dropdown in the bottom row where Back and Next are to save space?

I'm not aware of any possibility to do that. Maybe @rullzer has an idea, but to me it seems like the QWizard is limited to adding buttons on the bottom row.

Yep not easily without fighting with the whole wizard layout. I would leave that for later.

Is it possible to remove the whitespace under the scrollable container between the horizontal line? Or also remove the horizontal line?

There is a spacer there. Also removing that is not really easy as then it will look very strange and sticky if the wizard window is bigger or smaller etc.

Member

rullzer commented Aug 8, 2017

@juliushaertl @jancborchardt

is it possible to put the "Free plans" checkbox and "All" dropdown in the bottom row where Back and Next are to save space?

I'm not aware of any possibility to do that. Maybe @rullzer has an idea, but to me it seems like the QWizard is limited to adding buttons on the bottom row.

Yep not easily without fighting with the whole wizard layout. I would leave that for later.

Is it possible to remove the whitespace under the scrollable container between the horizontal line? Or also remove the horizontal line?

There is a spacer there. Also removing that is not really easy as then it will look very strange and sticky if the wizard window is bigger or smaller etc.

@juliushaertl juliushaertl referenced this pull request Aug 28, 2017

Open

Add provider list and registration to wizard #17

0 of 2 tasks complete
@juliushaertl

This comment has been minimized.

Show comment
Hide comment
@juliushaertl

juliushaertl Aug 28, 2017

Member

Closing in favour of #17

Member

juliushaertl commented Aug 28, 2017

Closing in favour of #17

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.