From 2d6eb10e297028cc8dde06c193c3acb21b08c668 Mon Sep 17 00:00:00 2001 From: "sagargurung1001@gmail.com" Date: Wed, 26 Jun 2024 15:41:37 +0545 Subject: [PATCH] Fix build issues and run unit tests Signed-off-by: sagargurung1001@gmail.com --- src/components/AdminSettings.vue | 41 +++++++++---------- src/components/OAuthConnectButton.vue | 3 +- src/components/PersonalSettings.vue | 2 +- src/components/admin/TextInput.vue | 1 - src/components/tab/SearchInput.vue | 1 - src/components/tab/WorkPackage.vue | 2 +- src/utils.js | 4 +- src/utils/workpackageHelper.js | 2 +- src/views/CreateWorkPackageModal.vue | 2 +- src/views/Dashboard.vue | 6 +-- src/views/LinkMultipleFilesModal.vue | 4 +- src/views/ProjectsTab.vue | 7 ++-- tests/jest/components/AdminSettings.spec.js | 34 +++++++-------- .../components/OAuthConnectButton.spec.js | 29 ++++--------- .../jest/components/PersonalSettings.spec.js | 4 +- tests/jest/components/tab/SearchInput.spec.js | 22 +++++----- tests/jest/views/Dashboard.spec.js | 8 ++-- .../jest/views/LinkMultipleFilesModal.spec.js | 2 +- tests/jest/views/ProjectsTab.spec.js | 24 +++++------ 19 files changed, 91 insertions(+), 107 deletions(-) diff --git a/src/components/AdminSettings.vue b/src/components/AdminSettings.vue index a2ded4e26..636f6330a 100644 --- a/src/components/AdminSettings.vue +++ b/src/components/AdminSettings.vue @@ -356,7 +356,6 @@ import axios from '@nextcloud/axios' import { loadState } from '@nextcloud/initial-state' import { generateUrl } from '@nextcloud/router' import { showSuccess, showError } from '@nextcloud/dialogs' -import '@nextcloud/dialogs/styles/toast.scss' import CheckBoldIcon from 'vue-material-design-icons/CheckBold.vue' import PencilIcon from 'vue-material-design-icons/Pencil.vue' import { NcLoadingIcon, NcCheckboxRadioSwitch, NcButton } from '@nextcloud/vue' @@ -764,7 +763,7 @@ export default { await this.clearOPOAuthClientValues() } }, - true + true, ) }, async clearOPOAuthClientValues() { @@ -794,7 +793,7 @@ export default { await this.resetAllAppValues() } }, - true + true, ) }, async resetAllAppValues() { @@ -820,7 +819,7 @@ export default { this.openProjectNotReachableErrorMessageDetails = null this.openProjectNotReachableErrorMessage = t( 'integration_openproject', - 'Please introduce a valid OpenProject hostname' + 'Please introduce a valid OpenProject hostname', ) if (response.data.result === true) { this.isOpenProjectInstanceValid = true @@ -834,30 +833,30 @@ export default { ) this.openProjectNotReachableErrorMessageDetails = t( 'integration_openproject', - 'The URL should have the form "https://openproject.org"' + 'The URL should have the form "https://openproject.org"', ) break case 'not_valid_body': this.openProjectNotReachableErrorMessage = t( 'integration_openproject', - 'There is no valid OpenProject instance listening at that URL, please check the Nextcloud logs' + 'There is no valid OpenProject instance listening at that URL, please check the Nextcloud logs', ) break case 'client_exception': { this.openProjectNotReachableErrorMessage = t( 'integration_openproject', - 'There is no valid OpenProject instance listening at that URL, please check the Nextcloud logs' + 'There is no valid OpenProject instance listening at that URL, please check the Nextcloud logs', ) this.openProjectNotReachableErrorMessageDetails = t( 'integration_openproject', - 'Response:' + 'Response:', ) + ' "' + response.data.details + '"' break } case 'server_exception': { this.openProjectNotReachableErrorMessage = t( 'integration_openproject', - 'Server replied with an error message, please check the Nextcloud logs' + 'Server replied with an error message, please check the Nextcloud logs', ) this.openProjectNotReachableErrorMessageDetails = response.data.details break @@ -868,14 +867,14 @@ export default { this.openProjectNotReachableErrorMessage = t( 'integration_openproject', - 'Accessing OpenProject servers with local addresses is not allowed.' + 'Accessing OpenProject servers with local addresses is not allowed.', ) this.openProjectNotReachableErrorMessageDetails = t( 'integration_openproject', 'To be able to use an OpenProject server with a local address, enable the `allow_local_remote_servers` setting. {htmlLink}.', { htmlLink }, null, - { escape: false, sanitize: false } + { escape: false, sanitize: false }, ) break } @@ -885,7 +884,7 @@ export default { this.openProjectNotReachableErrorMessage = t( 'integration_openproject', 'The given URL redirects to \'{location}\'. Please do not use a URL that leads to a redirect.', - { location } + { location }, ) break } @@ -895,7 +894,7 @@ export default { default: { this.openProjectNotReachableErrorMessage = t( 'integration_openproject', - 'Could not connect to the given URL, please check the Nextcloud logs' + 'Could not connect to the given URL, please check the Nextcloud logs', ) this.openProjectNotReachableErrorMessageDetails = response.data.details break @@ -965,7 +964,7 @@ export default { this.projectFolderSetupError = error.response.data.error } showError( - t('integration_openproject', 'Failed to save OpenProject admin options') + t('integration_openproject', 'Failed to save OpenProject admin options'), ) } this.notifyAboutOPOAuthTokenRevoke() @@ -986,17 +985,17 @@ export default { switch (this.oPOAuthTokenRevokeStatus) { case 'connection_error': showError( - t('integration_openproject', 'Failed to perform revoke request due to connection error with the OpenProject server') + t('integration_openproject', 'Failed to perform revoke request due to connection error with the OpenProject server'), ) break case 'other_error': showError( - t('integration_openproject', 'Failed to revoke some users\' OpenProject OAuth access tokens') + t('integration_openproject', 'Failed to revoke some users\' OpenProject OAuth access tokens'), ) break case 'success': showSuccess( - t('integration_openproject', 'Successfully revoked users\' OpenProject OAuth access tokens') + t('integration_openproject', 'Successfully revoked users\' OpenProject OAuth access tokens'), ) break default: @@ -1019,7 +1018,7 @@ export default { this.createNCOAuthClient() } }, - true + true, ) }, async completeIntegrationWithoutProjectFolderSetUp() { @@ -1057,7 +1056,7 @@ export default { await this.createNewAppPassword() } }, - true + true, ) }, async createNewAppPassword() { @@ -1077,7 +1076,7 @@ export default { }).catch((error) => { showError( t('integration_openproject', 'Failed to create Nextcloud OAuth client') - + ': ' + error.response.request.responseText + + ': ' + error.response.request.responseText, ) }) }, @@ -1094,7 +1093,7 @@ export default { }).catch(error => { showError( t('integration_openproject', 'Failed to save default user configuration') - + ': ' + error.response.request.responseText + + ': ' + error.response.request.responseText, ) }) }, diff --git a/src/components/OAuthConnectButton.vue b/src/components/OAuthConnectButton.vue index 0accef8f0..041d2aad6 100644 --- a/src/components/OAuthConnectButton.vue +++ b/src/components/OAuthConnectButton.vue @@ -15,7 +15,6 @@ import { generateUrl } from '@nextcloud/router' import { showError } from '@nextcloud/dialogs' import { getCurrentUser } from '@nextcloud/auth' import { translate as t } from '@nextcloud/l10n' -import '@nextcloud/dialogs/styles/toast.scss' import { NcButton } from '@nextcloud/vue' import OpenInNewIcon from 'vue-material-design-icons/OpenInNew.vue' import dompurify from 'dompurify' @@ -89,7 +88,7 @@ export default { .catch((error) => { showError( t('integration_openproject', 'Failed to redirect to OpenProject') - + ': ' + error.message + + ': ' + error.message, ) }) }, diff --git a/src/components/PersonalSettings.vue b/src/components/PersonalSettings.vue index cde003ab3..1e9495a14 100644 --- a/src/components/PersonalSettings.vue +++ b/src/components/PersonalSettings.vue @@ -123,7 +123,7 @@ export default { : error.response?.request?.responseText showError( t('integration_openproject', 'Failed to save OpenProject options') - + ': ' + msg + + ': ' + msg, ) }) .finally(() => { diff --git a/src/components/admin/TextInput.vue b/src/components/admin/TextInput.vue index 2e8f12417..ee834fce3 100644 --- a/src/components/admin/TextInput.vue +++ b/src/components/admin/TextInput.vue @@ -50,7 +50,6 @@