Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Privacy - Auto-Complete with emails from the instance #848
Steps to reproduce
You should see auto-completion from your address book or your group.
You see auto-completion from the full instance, which is a privacy leak.
Mail app version: 0.7.10
This issue is a regression from #171.
Tried to reproduce on my dev instance and I can confirm that other system users are suggested for the autocompletion. Is that what you observed?
I also added a contact to another user's address book via the contacts app but that one was not listed.
Looks like the
It's the DAV app that registers both the user's address book and the system address book: https://github.com/nextcloud/server/blob/7b4e51dbc71c1112663b65c08b14eed44dcb50a3/apps/dav/lib/CardDAV/ContactsManager.php#L55-L59
It kinda feels wrong to hack this into the DAV app. This doesn't seem like the appropriate place. Also, I have the feeling change will cause other problems as well as these address books are not only used for Mail but also for example in the contacts menu …
added a commit
Mar 28, 2018
referenced this issue
Mar 28, 2018
Fixed (aka hacked) it in the mail app instead. See #856