New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCP files as composer dependency #539

Merged
merged 3 commits into from Sep 22, 2017

Conversation

@ChristophWurst
Member

ChristophWurst commented Sep 20, 2017

This allows better CI analyses where Nextcloud's files are not
available because only the app repository is cloned.

This is a little experiment, let's see how well that actually works …

Add OCP files as composer dependency
This allows better CI analyses where Nextcloud's files are not
available because only the app repository is cloned.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

@ChristophWurst ChristophWurst added this to the 0.7.4 milestone Sep 20, 2017

@ChristophWurst ChristophWurst self-assigned this Sep 20, 2017

@ChristophWurst ChristophWurst added this to IN PROGRESS (max 3) in Christoph's Tasks Sep 20, 2017

@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst

ChristophWurst Sep 20, 2017

Member

Scrutinizer analyzed the package
bildschirmfoto von 2017-09-20 13-15-41

Member

ChristophWurst commented Sep 20, 2017

Scrutinizer analyzed the package
bildschirmfoto von 2017-09-20 13-15-41

@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst

ChristophWurst Sep 20, 2017

Member

Scrutinizer — 11 new issues, 2 updated code elements

Exactly what I expected: it now finds exception classes it reported as non-existing before and complains about wrong parameter types passed to OCP classes/interfaces. Awesome 🚀 🤖 💃

Member

ChristophWurst commented Sep 20, 2017

Scrutinizer — 11 new issues, 2 updated code elements

Exactly what I expected: it now finds exception classes it reported as non-existing before and complains about wrong parameter types passed to OCP classes/interfaces. Awesome 🚀 🤖 💃

Install package via packagist
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

@ChristophWurst ChristophWurst requested a review from rullzer Sep 20, 2017

@ChristophWurst ChristophWurst moved this from IN PROGRESS (max 3) to TO REVIEW (max 4) in Christoph's Tasks Sep 20, 2017

@ChristophWurst ChristophWurst requested a review from LukasReschke Sep 21, 2017

Only require ocp classes for development
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

@ChristophWurst ChristophWurst merged commit 051c4d5 into master Sep 22, 2017

3 checks passed

Scrutinizer 11 new issues, 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.0%
Details

@ChristophWurst ChristophWurst deleted the enhancement/composer-ocp-files branch Sep 22, 2017

@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4) to DONE in Christoph's Tasks Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment