New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Microsoft xoauth2 support #7722
Conversation
I'm facing a little challenge here. Generally speaking, IMAP accounts with password auth require us to ask the user for a password. XOAUTH2 accounts do not need a password but use a popup screen for the vendor. With the Gmail XOAUTH2 integration I chose to hide the password input as soon as someone enters an email address that ends with Now, with Microsoft, it seems even more likely that someone uses a domain that doesn't easily allow us to detect it's hosted by Microsoft. Some accounts seem to end with A more sophisticated approach for detecting Gmail and Microsoft accounts is to use the IMAP and SMTP hosts found by auto config detection. But auto config detection only happens after the user clicks on Connect. At that point we should already have hidden the password, or not. So there are at least two approaches we can take here.
For simplicity I'll probably go with the first one. |
I'm looking forward to seeing this support in Nextcloud Mail! |
|
When this is merged, how long will it take to receive it as an update? |
|
Please be patient and refrain from commenting on PRs unless the comment adds value to the code changes or discussion. We are struggling too many notifications already. The comments just slow us down. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works with my personal account.
6faf6ef
to
c6f540a
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
eec881a
to
65a9000
Compare

Fixes #6591
Todo