New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help view for keyboard shortcuts #91

Merged
merged 10 commits into from Jun 20, 2017

Conversation

Projects
3 participants
@Gomez
Member

Gomez commented Sep 20, 2016

No description provided.

Show outdated Hide outdated js/templates/keyboard-shortcuts.html
Show outdated Hide outdated js/templates/settings.html
Show outdated Hide outdated js/views/appview.js
Show outdated Hide outdated js/views/settings.js

@ChristophWurst ChristophWurst added this to the 0.6.1 milestone Sep 20, 2016

@ChristophWurst ChristophWurst modified the milestones: 0.6.2, 0.6.3 Dec 8, 2016

Gomez and others added some commits Oct 20, 2016

@Gomez Gomez added 3. to review and removed 2. developing labels Mar 27, 2017

@Gomez

This comment has been minimized.

Show comment
Hide comment
@Gomez

Gomez Mar 28, 2017

Member

All tests pass, ready for review @nextcloud/mail

Member

Gomez commented Mar 28, 2017

All tests pass, ready for review @nextcloud/mail

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Mar 29, 2017

Member

Working on the design atm :)

Member

jancborchardt commented Mar 29, 2017

Working on the design atm :)

@Gomez Gomez added 2. developing and removed 3. to review labels Mar 29, 2017

@ChristophWurst

Code looks very good! I just found some nitpicks :)

});
});
});

This comment has been minimized.

@ChristophWurst

ChristophWurst Apr 1, 2017

Member

new line missing

@ChristophWurst

ChristophWurst Apr 1, 2017

Member

new line missing

improve design of keyboard shortcuts view
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Apr 1, 2017

Member

Added a commit to improve the design, please also review core nextcloud/server#4183 (needs backports also)

Member

jancborchardt commented Apr 1, 2017

Added a commit to improve the design, please also review core nextcloud/server#4183 (needs backports also)

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt
Member

jancborchardt commented Apr 1, 2017

capture du 2017-03-30 12-51-15

ChristophWurst added some commits Jun 19, 2017

Fix changelog
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Add proper routing support
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst

ChristophWurst Jun 19, 2017

Member

Fixed/added proper URL routing support.

Member

ChristophWurst commented Jun 19, 2017

Fixed/added proper URL routing support.

@ChristophWurst

👍 for @Gomez's part. Nicely done, thanks :)

@ChristophWurst ChristophWurst added this to TO REVIEW (max 4) in Christoph's Tasks Jun 19, 2017

@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst

ChristophWurst Jun 19, 2017

Member

@nextcloud/mail please give this a quick test. This is ready to be integrated into master IMO.

Member

ChristophWurst commented Jun 19, 2017

@nextcloud/mail please give this a quick test. This is ready to be integrated into master IMO.

@ChristophWurst

This comment has been minimized.

Show comment
Hide comment
@ChristophWurst

ChristophWurst Jun 20, 2017

Member

The major changes are from @Gomez which I've approved -> merging this now 🚀

Member

ChristophWurst commented Jun 20, 2017

The major changes are from @Gomez which I've approved -> merging this now 🚀

@ChristophWurst ChristophWurst merged commit 3397e01 into master Jun 20, 2017

3 of 4 checks passed

VersionEye Some dependencies have no license.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 32.802%
Details

@ChristophWurst ChristophWurst deleted the shortcut_help branch Jun 20, 2017

@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4) to DONE in Christoph's Tasks Jun 20, 2017

@ChristophWurst ChristophWurst modified the milestones: 0.6.5, 0.7 Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment