New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken navigation keys in 13beta3 #239

Closed
janumix opened this Issue Dec 14, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@janumix

janumix commented Dec 14, 2017

Explain the Problem

Navigation keys 'J' and 'K' (next, previous news) are broken. There are some keypress actions but hard to describe the order of articles application jumps to.

Steps to Reproduce

Just press 'J' on very top article in whatever folder.

System Information

  • News app version: 11.0.5
  • Nextcloud version: 13 best 3
  • PHP version: 17.1.9
  • Database and version: MySQL/MariaDB 10.0.31
  • Browser and version: Chrome 63.0.3239.84
  • Distribution and version:

Contents of nextcloud/data/nextcloud.log

Nothing related to application

@BernhardPosselt

This comment has been minimized.

Member

BernhardPosselt commented Dec 29, 2017

Mark read on scroll is broken as well. I suppose its related to https://github.com/nextcloud/news/blob/master/js/directive/NewsScroll.js#L52 and https://github.com/nextcloud/news/blob/master/js/gui/KeyboardShortcuts.js which doesnt detect the proper distance anymore

@BernhardPosselt

This comment has been minimized.

Member

BernhardPosselt commented Dec 29, 2017

A commit in server broke this, latest master works fine on my Nextcloud 12 install

@ChristophWurst @MorrisJobke @jancborchardt any idea?

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented Dec 29, 2017

@BernhardPosselt Check this commit: nextcloud/server#7431
Maybe it is?

@BernhardPosselt

This comment has been minimized.

Member

BernhardPosselt commented Jan 3, 2018

@skjnldsv yes, works before that one

@jancborchardt

This comment has been minimized.

Member

jancborchardt commented Jan 5, 2018

@skjnldsv do you have any idea what could fix it? :)

@skjnldsv

This comment has been minimized.

Member

skjnldsv commented Jan 5, 2018

Yeah, it's in my todo list :)

@skjnldsv skjnldsv self-assigned this Jan 11, 2018

@BernhardPosselt BernhardPosselt changed the title from Broken navigation keys in 13beta3 to Nextcloud 13 issues Jan 23, 2018

@BernhardPosselt BernhardPosselt changed the title from Nextcloud 13 issues to Broken navigation keys in 13beta3 Jan 23, 2018

@BernhardPosselt

This comment has been minimized.

Member

BernhardPosselt commented Jan 23, 2018

Closed in favor of #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment