New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 12.0 #280

Closed
MariusBluem opened this Issue May 22, 2017 · 94 comments

Comments

Projects
None yet
@MariusBluem
Copy link
Member

MariusBluem commented May 22, 2017

@kyrofa

kyrofa added a commit to kyrofa/nextcloud-snap that referenced this issue May 22, 2017

nextcloud: update to v12.0.0
Resolve nextcloud#280.

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented May 23, 2017

Thanks @MariusBluem. Would you mind taking a look at #281 (there are testing instructions there)? Something is wrong here... at least in firefox, I'm getting this:

screenshot from 2017-05-22 20-37-47

I'm not sure where the MIME type mismatch is coming from, all I'm changing here is the Nextcloud version. Are there requirements of which I'm unaware?

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented May 23, 2017

Currently blocked on nextcloud/server#5057.

@oparoz

This comment has been minimized.

Copy link
Member

oparoz commented May 23, 2017

Any chance (technically) of catching these problems via CI and acceptance tests?

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented May 23, 2017

Yes, although we'd need an environment in which we could run the snap (the travis kernel doesn't use the right config), as well as a test suite to run (e.g. I have some experience with capybara). Does Nextcloud have an acceptance suite?

@oparoz

This comment has been minimized.

Copy link
Member

oparoz commented May 23, 2017

We use drone, so could use a docker which loads snaps.
Then there are some acceptance tests which can be run:
https://github.com/nextcloud/server/tree/master/tests/acceptance

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented May 23, 2017

Yeah that would work well. Would it be possible to get access to your drone infrastructure?

@MariusBluem

This comment has been minimized.

Copy link
Member

MariusBluem commented May 23, 2017

@MorrisJobke for Drone infrastructure

@oparoz

This comment has been minimized.

Copy link
Member

oparoz commented May 23, 2017

@kyrofa I think it should be possible to use it, but I wouldn't expect anything to happen until mid-June.

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented May 24, 2017

@MorrisJobke for Drone infrastructure

Enabled. 60 minute time limitation per job. Also pull and push hooks are in here. Please use something like https://github.com/nextcloud/server/blob/master/.drone.yml#L672 to avoid running pushes to PRs with a branch in the same repo twice ;)

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented May 30, 2017

I'm afraid the acceptance tests in Nextcloud make too many assumptions about running from source. They will not work against the snap (or indeed any package).

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented May 30, 2017

I've written a few very simple acceptance tests that would have caught the blocking issue, but unfortunately Drone won't run snaps either. Circle CI will though-- would someone with power mind enabling that for me?

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented May 30, 2017

Argh, but Circle CI won't BUILD them! It's still trusty, just with a xenial kernel. How frustrating.

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented May 31, 2017

Ah ha-- Circle CI DOES work. I just have to build in docker, then run outside of docker. So yeah, @MorrisJobke do you think you could enable that?

@MorrisJobke

This comment has been minimized.

Copy link
Member

MorrisJobke commented May 31, 2017

Ah ha-- Circle CI DOES work. I just have to build in docker, then run outside of docker. So yeah, @MorrisJobke do you think you could enable that?

Should be enabled now: https://circleci.com/gh/nextcloud/nextcloud-snap

@sempervictus

This comment has been minimized.

Copy link

sempervictus commented Jul 4, 2017

The dependency seems to have been addressed. Any change of a v12 snap?

@pachulo

This comment has been minimized.

Copy link
Collaborator

pachulo commented Jul 4, 2017

@sempervictus I think that is worth it to wait till they do a proper release:

Instead of just taking a snapshot of the stable12 branch.

@maiki

This comment has been minimized.

Copy link

maiki commented Jul 5, 2017

@pachulo I am not tracking ya there: v12 was released in May, the same day this issue was raised. If that isn't what ya meant, could you clarify?

@pachulo

This comment has been minimized.

Copy link
Collaborator

pachulo commented Jul 5, 2017

hey @maiki ! Yeah, I will try to clarify: nextcloud 12.0.0 was released in May but included this bug. The fix is now already merged in master and stable12 branches of nextcloud, but they still haven't released a version with the fix included (that will be version 12.0.1):

Once they release it, the snap will be updated (if no other flaws affect it).

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Jul 20, 2017

Another issue caused by updating to v12: nextcloud/server#5532.

@SkyWheel

This comment has been minimized.

Copy link

SkyWheel commented Jul 21, 2017

@kyrofa , btw, just upgaded to 12/edge channel and my theming has disappeared. I've tried to changed background and logo once again - it didn't help. Probably it is related to this new issue.

@SkyWheel

This comment has been minimized.

Copy link

SkyWheel commented Aug 7, 2017

Finally the upstream 12.0.1 has been released!

pachulo added a commit to pachulo/nextcloud-snap that referenced this issue Aug 7, 2017

@pachulo

This comment has been minimized.

Copy link
Collaborator

pachulo commented Aug 7, 2017

I've opened a PR to see how this version behaves.

pachulo added a commit to pachulo/nextcloud-snap that referenced this issue Aug 7, 2017

@shadowempire123

This comment has been minimized.

Copy link

shadowempire123 commented Dec 5, 2017

root@nextcloud:/# sudo nextcloud.occ upgrade
The process control (PCNTL) extensions are required in case you want to interrupt long running commands - see http://php.net/manual/en/book.pcntl.php
Nextcloud is already latest version
root@nextcloud:/#

@shadowempire123

This comment has been minimized.

Copy link

shadowempire123 commented Dec 5, 2017

still in Maintenance mode....

@shadowempire123

This comment has been minimized.

Copy link

shadowempire123 commented Dec 5, 2017

how can I rollback?

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 5, 2017

Huh, no idea what's happening there. Disabling maintenance mode doesn't seem to actually do it, eh? Yeah, to get back up and running try sudo snap revert nextcloud which will revert back a revision.

@shadowempire123

This comment has been minimized.

Copy link

shadowempire123 commented Dec 5, 2017

Well, rollback succeeded.

@shadowempire123

This comment has been minimized.

Copy link

shadowempire123 commented Dec 5, 2017

Back to 11.0.5snap2

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 5, 2017

I'll try an upgrade a bit later as well, see if I can duplicate.

@shadowempire123

This comment has been minimized.

Copy link

shadowempire123 commented Dec 5, 2017

Let me know how i can Help....

@niemalsnever

This comment has been minimized.

Copy link

niemalsnever commented Dec 5, 2017

Tried an upgrade just now, it went without any problems. I just received my Nextcloud Box last month, so I didn't have time to fiddle with anything other than enabling SSH. Running the Snap (or more precisely the entire Nextcloud Box image) on a RaspberryPi 3B.

@maiki

This comment has been minimized.

Copy link

maiki commented Dec 5, 2017

@shadowempire123 and @kyrofa, please troubleshoot in a different place next time. This ticket is tracking the snap update status, not for troubleshooting specific upgrade errors; a new issue or the forums would be a better place to discuss. Thanks.

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 5, 2017

@maiki um. @shadowempire123 was helping test out the snap update. Could that have been done on the PR? Yes, but I requested testing here as well, and got feedback here. I'm not going to tell someone "please test the fix for this issue, but let's go talk about it in the forums." I'm just thankful that people are helping me test it out.

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 5, 2017

Thanks @niemalsnever! I appreciate the feedback. I have no idea how the firmware upgrade could have affected this, but you never know.

@maiki

This comment has been minimized.

Copy link

maiki commented Dec 5, 2017

I'm not going to tell someone "please test the fix for this issue, but let's go talk about it in the forums." I'm just thankful that people are helping me test it out.

@kyrofa I don't think that is a bad idea. Or maybe open another issue and link to this one. I need to track this issue, but I just read a bunch of messages that weren't relevant. If there is a better place for proposals, let me know and I will submit it there. Just trying to cut back on email. 😄

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 5, 2017

Fair enough @maiki, I hear you, and can certainly appreciate the problem! I'll try to encourage fix testing discussions to happen on the PR.

@shadowempire123

This comment has been minimized.

Copy link

shadowempire123 commented Dec 5, 2017

just a last update from my side:
I did the rollback. Then I tried again to update with sudo snap refresh nextcloud --channel=stable/pr-388.
Now the update went through and I am on 12.0.4.

Thx for your support.
maybe the problem was caused from my side because I did a reboot (me=windows user ;)) right after my first update which failed.

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 5, 2017

Now the update went through and I am on 12.0.4.

How odd! Well, I'm glad it worked on the second try, we'll see if anyone else has similar issues. Thanks for taking another run at it!

@kyrofa kyrofa added fix-in-beta and removed upstream labels Dec 7, 2017

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 7, 2017

The fix for this issue has been merged. Once builds have completed it will be available in the beta channel.

@michelvandun

This comment has been minimized.

Copy link

michelvandun commented Dec 7, 2017

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 8, 2017

The call for testing is out, folks. The more testers the merrier!

@ymakhloufi

This comment has been minimized.

Copy link

ymakhloufi commented Dec 11, 2017

Is there an ETA on when this is gonna be merged into master?

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 11, 2017

@ymakhloufi this is the issue, not the PR (which is #390). Questions concerning the PR (including upgrade issues/questions) are best asked over there. @FoxBJK would you mind moving your question over there as well, please?

@kyrofa kyrofa closed this in 1e26c91 Dec 12, 2017

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 12, 2017

This should be rolling out to everyone soon, thanks to all the testers! ❤️

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 13, 2017

It's now in stable. If you refreshed to candidate in order to test, feel free to refresh back:

$ sudo snap refresh --stable nextcloud
@niemalsnever

This comment has been minimized.

Copy link

niemalsnever commented Dec 13, 2017

@kyrofa Thanks for the heads up, I was planning on asking about that.

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 13, 2017

Sure thing. There isn't a problem with anyone staying on candidate, of course. You'll just automatically update when release candidates come out, which tend to be stable. If you want even more stability, get back on stable. More info on the release strategy page (which I need to update a little).

@aitrone

This comment has been minimized.

Copy link

aitrone commented Dec 13, 2017

Hello

Today in the morning the server has updated spontaneously "starting upgrade from 11.0.5.1 to 12.0.4.3". All the styles have dropped and now i can't change neither background nor logo. Please help.

@kyrofa

This comment has been minimized.

Copy link
Member

kyrofa commented Dec 13, 2017

@aitrone sounds like #394, which appears to be another CSS issue when theming. Please comment on that issue, and respond to my request there for more info if you're able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment