/nextcloud-snap

Add samba client #60

Open
oparoz opened this Issue Sep 26, 2016 · 8 comments

Comments

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
6 participants
@oparoz @wouterAA @taschenlampe @fishscene @kyrofa @devz3r0
@oparoz
Owner

oparoz commented Sep 26, 2016

Adding the samba client to PHP would make it possible to access other storage located on the same network.

@oparoz oparoz added feature starter issue labels Sep 26, 2016

@kyrofa kyrofa removed the starter issue label Oct 11, 2016

@wouterAA

wouterAA commented Dec 7, 2016

I could really use this feature. One of the reasons I bought the Owncloud box was to have a web interface to my external samba shares. For now I configured it over SFTP but I would really like to just the samba shares.
@taschenlampe

taschenlampe commented Dec 16, 2016

Would like to see this feature too. Regards.
@fishscene

fishscene commented Feb 17, 2017

I too would like to see this feature.
This was opened several months ago - is there a status update on where this might be at? (planning/on roadmap/etc..?)

Thanks!
@kyrofa
Member

kyrofa commented Feb 17, 2017 •
Edited 1 time

I personally have very little experience with samba, so I'm probably not the right person to be playing with this. As such, as far as I'm concerned, this is currently not on the roadmap. I'm of course willing to accept contributions for this though, as long as it doesn't bloat the snap too much or introduce security concerns.
@fishscene

fishscene commented Feb 17, 2017

Thanks for the fast response, @kyrofa.

I have decent experience getting samba running on Ubuntu. But zero experience with programming or integrating anything with a web interface.
Since samba/cifs is heavily used by many folks (even if they don't realize they are using it), I can imagine a lot of folks looking forward to this feature - especially if they have a home NAS. If anyone is capable of providing a PR for this, know that I would be very appreciative of your work.

I can of course, dabble, but if I do submit a PR, it would require heavy scrutinizing.

This was referenced May 5, 2017

Closed
Merged

pachulo added a commit to pachulo/nextcloud-snap that referenced this issue May 10, 2017

@pachulo
Add samba client support. 
With libsmbclient-php and libsmbclient.

Fixes #60

Note: We had to install libsmbclient from the python plugin, as it's
python dependency conflicted with the python pulled by the certbot part
when directly staged.
See: https://bugs.launchpad.net/snapcraft/+bug/1630996
873c175

@kyrofa kyrofa closed this in #263 May 10, 2017

@kyrofa kyrofa referenced this issue May 10, 2017

Closed

Add sambaclient support #270

@kyrofa
Member

kyrofa commented May 10, 2017

Whoops, bad merge. Let's try that again.

@kyrofa kyrofa reopened this May 10, 2017

kyrofa added a commit to kyrofa/nextcloud-snap that referenced this issue May 10, 2017

@pachulo @kyrofa
Add samba client support. 
With libsmbclient-php and libsmbclient.

Fixes #60

Note: We had to install libsmbclient from the python plugin, as it's
python dependency conflicted with the python pulled by the certbot part
when directly staged.
See: https://bugs.launchpad.net/snapcraft/+bug/1630996
c22b076

@kyrofa kyrofa referenced this issue May 10, 2017

Merged

Add samba client support. #271

@kyrofa kyrofa added the fix-in-beta label May 10, 2017

@kyrofa kyrofa added this to the 11.0.3snap2 milestone May 10, 2017

@devz3r0

devz3r0 commented May 12, 2017 •
Edited 1 time

#272
Hi I opened an issue because of a connecting problem.

@kyrofa kyrofa referenced this issue May 15, 2017

Merged

Revert "Add samba client support." #273

@kyrofa kyrofa removed the fix-in-beta label May 15, 2017

@kyrofa
Member

kyrofa commented May 15, 2017

Sorry everyone, #272 found enough issues to revert the samba feature so as to not block release of security updates. We're still working on it.

@kyrofa kyrofa removed this from the 11.0.3snap2 milestone May 15, 2017

@kyrofa kyrofa closed this in 9acd46f May 16, 2017

@kyrofa kyrofa reopened this May 16, 2017

pachulo added a commit to pachulo/nextcloud-snap that referenced this issue Dec 18, 2017

@pachulo
Add samba client support. 
With libsmbclient-php and libsmbclient.

Fixes #60

Note: We had to install libsmbclient from the python plugin, as it's
python dependency conflicted with the python pulled by the certbot part
when directly staged.
See: https://bugs.launchpad.net/snapcraft/+bug/1630996
5f501eb

pachulo added a commit to pachulo/nextcloud-snap that referenced this issue Dec 18, 2017

@pachulo
Add samba client support. 
With libsmbclient-php and libsmbclient.

Fixes #60

Note: We had to install libsmbclient from the python plugin, as it's
python dependency conflicted with the python pulled by the certbot part
when directly staged.
See: https://bugs.launchpad.net/snapcraft/+bug/1630996
bea628b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment