Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Encryption Settings #616

Closed
ilfrigorifero opened this issue Jun 18, 2018 · 9 comments

Comments

@ilfrigorifero
Copy link

commented Jun 18, 2018

Hi there,

I've like to disable TLS 1.0 and only use TLS 1.1 and TLS 1.2.
All i could find was a Wiki entry from 2017 saying I should edit /var/snap/nextcloud/current/apache/config/ but that folder and its content seem to have vanished since the Wiki entry was last edited.

What can I do to edit these settings?

@r4co0n

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2018

Unfortunately, it's not as easy as that, as the content of the snap itself is immutable.

I think this issue is a feature request, and an easy one at that, and will tag it accordingly. If you disagree, just let us know.

@ilfrigorifero

This comment has been minimized.

Copy link
Author

commented Jun 18, 2018

@pachulo

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2018

@kyrofa

This comment has been minimized.

Copy link
Member

commented Jul 9, 2018

Indeed, I want to try just disabling these and seeing what ssllabs says about it.

@ASmith-

This comment has been minimized.

Copy link

commented Jul 27, 2018

Many folks are using only the PFS cipher suites exclusively on their web server settings. Those contain the strongest ciphers and form TLS v1.2 and soon TLS v1.3. Nearly all web browsers now can work just fine with TLS v1.2 PFS cipher suites and you are using the strongest connective end to end encryption possible using openssl libraries. My suggestion to kick upstream is gut everything but PFS (Perfect Forward Secrecy) ciphers as those are the strongest available and publicly supported.

Perfect Forward Secrecy is obtained by using Ephemeral Diffie-Helman keys (DHE or EDH). So to get the cipher suits in that list that support PFS you could do:

$ openssl ciphers -v aECDSA:aECDH:kEDH:kRSA | grep DHE

This will include ciphers based on ECDHE (Elliptic Curve) as well as DHE (RSA). An advantage of ECDHE is that it is a lot faster than DHE. However in the list generated by that command there are still quite a few weak ciphers that use weak or no crypto: DES, RC4, SSLv3, NULL.

All of those happened to have SSLv3 in common, so by excluding SSLv3 you get a list of 12 solid ciphers:

$ openssl ciphers -v aECDSA:aECDH:kEDH:kRSA | grep DHE | grep -v SSLv3

ECDHE-ECDSA-AES256-GCM-SHA384 TLSv1.2 Kx=ECDH Au=ECDSA Enc=AESGCM(256) Mac=AEAD
ECDHE-ECDSA-AES256-SHA384 TLSv1.2 Kx=ECDH Au=ECDSA Enc=AES(256) Mac=SHA384
ECDHE-ECDSA-AES128-GCM-SHA256 TLSv1.2 Kx=ECDH Au=ECDSA Enc=AESGCM(128) Mac=AEAD
ECDHE-ECDSA-AES128-SHA256 TLSv1.2 Kx=ECDH Au=ECDSA Enc=AES(128) Mac=SHA256
DHE-DSS-AES256-GCM-SHA384 TLSv1.2 Kx=DH Au=DSS Enc=AESGCM(256) Mac=AEAD
DHE-RSA-AES256-GCM-SHA384 TLSv1.2 Kx=DH Au=RSA Enc=AESGCM(256) Mac=AEAD
DHE-RSA-AES256-SHA256 TLSv1.2 Kx=DH Au=RSA Enc=AES(256) Mac=SHA256
DHE-DSS-AES256-SHA256 TLSv1.2 Kx=DH Au=DSS Enc=AES(256) Mac=SHA256
DHE-DSS-AES128-GCM-SHA256 TLSv1.2 Kx=DH Au=DSS Enc=AESGCM(128) Mac=AEAD
DHE-RSA-AES128-GCM-SHA256 TLSv1.2 Kx=DH Au=RSA Enc=AESGCM(128) Mac=AEAD
DHE-RSA-AES128-SHA256 TLSv1.2 Kx=DH Au=RSA Enc=AES(128) Mac=SHA256
DHE-DSS-AES128-SHA256 TLSv1.2 Kx=DH Au=DSS Enc=AES(128) Mac=SHA256

@Airtdschahn

This comment has been minimized.

Copy link

commented Mar 13, 2019

Hello everyone,

could we disable TLSv1.1 and v1.0 and all CBC-ciphers in the next stable release (it‘s a great image, but this is for me the most annoying point, that I have to break the update mechanism of snap and edit the ssl.conf for every stable release manuelly).

example configuration pull request #937

(Sorry for trying to merge the pull request, it‘s the first time i‘m using Github).

kyrofa added a commit to kyrofa/nextcloud-snap that referenced this issue Mar 16, 2019

apache: disable TLS 1.0 and 1.1 and strengthen ciphers
Balancing client support and security, now seems a good time to disable
TLS 1.0 and 1.1 and update the cipher list in such a way that both
SSLLabs and ssltest are happy:

- Limit ciphers to those that support forward secrecy
- Get rid of CBC ciphers

Resolve nextcloud#616
Resolve nextcloud#737

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>

kyrofa added a commit to kyrofa/nextcloud-snap that referenced this issue Mar 16, 2019

apache: disable TLS 1.0 and 1.1 and strengthen ciphers
Balancing client support and security, now seems a good time to disable
TLS 1.0 and 1.1 and update the cipher list in such a way that both
SSL Labs and ssltest are happy:

- Limit ciphers to those that support forward secrecy
- Get rid of CBC ciphers

Resolve nextcloud#616
Resolve nextcloud#737

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>

kyrofa added a commit to kyrofa/nextcloud-snap that referenced this issue Mar 16, 2019

apache: disable TLS 1.0 and 1.1 and strengthen ciphers
Balancing client support and security, now seems a good time to disable
TLS 1.0 and 1.1 and update the cipher list in such a way that both
SSL Labs and testssl.sh are happy:

- Limit ciphers to those that support forward secrecy
- Get rid of CBC ciphers

Resolve nextcloud#616
Resolve nextcloud#737

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>

kyrofa added a commit to kyrofa/nextcloud-snap that referenced this issue Mar 16, 2019

apache: disable TLS 1.0 and 1.1 and strengthen ciphers
Balancing client support and security, now seems a good time to disable
TLS 1.0 and 1.1 and update the cipher list in such a way that both
SSL Labs and testssl.sh are happy:

- Limit ciphers to those that support forward secrecy
- Get rid of CBC ciphers

Resolve nextcloud#616
Resolve nextcloud#737

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa

This comment has been minimized.

Copy link
Member

commented Mar 16, 2019

Please take a look at #941.

@Airtdschahn

This comment has been minimized.

Copy link

commented Mar 23, 2019

Hello everyone,

I refreshed my snap install on my test installation with pr-941 (--channel=beta/pr-941)
SSL Labs
and tested it with win7 (Build 7601 with SP1)
Windows 7
and ie11 (11.0.9600),
Internet Explorer 11
and everything works great (Connection: TLS 1.2, AES with 256 bit encryption (High); DH with 4096 bit exchange),
Nextcloud 15
I am repeating myself again and again, but you all (especially kyrofa) do great work with this snap!

@kyrofa

This comment has been minimized.

Copy link
Member

commented Mar 23, 2019

Thank you for taking that for a spin, @Airtdschahn! I was relying completely on simulators, very happy to see it working on the real deal.

@kyrofa kyrofa added the fix-in-beta label Mar 23, 2019

@kyrofa kyrofa closed this in e880e72 Mar 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.