Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
nextcloud: update to v12.0.1 #334
Conversation
kyrofa
requested changes
Aug 7, 2017
•
The diff looks good, builds are spinning up now for us to test. However, your commit message is currently the following:
nextcloud: update to v12.0.1
Revolves #280
Would you mind changing the "revolves" to "resolve" so it actually closes #280 if/when merged to master? Go ahead and amend and force-push.
|
Alright, this PR is now available for testing in the
Or, if you already have it installed:
|
|
Still definitely suffers from nextcloud/server#5532 . I also can't create new contacts, the only feedback being this in my console when I hit the "new contact" button: There are still some javascript issues with this release. |
|
Huh... maybe that's just a contacts app issue? https://help.nextcloud.com/t/contacts-addressbook-is-undefined/14262 |
|
Wow, yeah... click the gear icon, create a new addressbook, and THEN you can create new contacts. The UX is dreadful. There's no default calendar either, but at least the fact that you need one is more clear. It's odd though, in 11.0.3 they both create an addressbook and calendar by default. Wonder why the regression. |
|
At least both the calendar and contacts pick up the addressbook and default calendar when upgrading from 11.0.3, so that terrible UX will only bite brand new users, not those upgrading. |
This was referenced Aug 8, 2017
escoand
commented
Aug 22, 2017
|
The version string of the snap is still old. |
Yeah, while the version of the snap is related to the contained version of Nextcloud, the snap's version isn't actually updated until that particular snap is released. |
|
Logged nextcloud/contacts#300 . |
|
Well, good news at last! I've modified the files modified in this PR nextcloud/server#6332 in my snap (as commented here nextcloud/server#6028) and the problem whit the spinning circle appearing before the configuration and the missing icons for the files app are gone!! The fix should be applied in 12.0.4 but maybe we can convince them to apply it to 12.0.3...what do you think @kyrofa ? |
|
OK, I think that I made a mistake, I was not testing 12.0.1 but 11.0.4... @kyrofa could it be that right now this:
Installs the stable channel snap (revision #2707 as of now) and not the snap corresponding to this PR? |
|
@pachulo ah indeed, they expire after a month and revert back to stable. Let me get them back up. |
|
Well, I just tried with:
And then modified the files, but the issue is still there...guess it's time to go to bed :( |
|
Ah darn, you got my hopes up! That fix didn't actually fix anything, then? Did you try the theming change suggested to regenerate the files? |
|
Yeah, it did not fix anything. Changing the color didn't help either. |
|
12.0.3 is out, have had any luck here? |
|
Hey @jospoortvliet, I'm afraid not. CSS is still broken, which rears its head in a number of ways, including: nextcloud/server#6028 and nextcloud/server#5532, and nextcloud/server#5289 is concerning as well. You can test out daily-stable12 (which is beyond 12.0.3 now) yourself with:
|
|
No need to keep this open if we can't continue. |



pachulo commentedAug 7, 2017
Revolves #280