New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the rich message when available and instead of trim overlay with a shadow #190

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Copy link
Member

nickvergessen commented Oct 23, 2018

I now put a "white" (background color) shadow over long texts (200+ chars) instead of trimming them, so it doesn't break with user profiles etc when they are at the cutting border.

bildschirmfoto von 2018-10-23 16-17-42

cc @rullzer @skjnldsv @jancborchardt

Use the rich message when available and instead of trim overlay with …
…a shadow

Signed-off-by: Joas Schilling <coding@schilljs.com>
@rullzer

This comment has been minimized.

Copy link
Member

rullzer commented Oct 23, 2018

I like it!

@ChristophWurst
Copy link
Member

ChristophWurst left a comment

Looks good!

@rullzer
Copy link
Member

rullzer left a comment

Lets do it! 🚀

@nickvergessen

This comment has been minimized.

Copy link
Member

nickvergessen commented Oct 24, 2018

Oracle fail is unrelated

@nickvergessen nickvergessen merged commit 8a20b38 into master Oct 24, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer No new issues
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/drone/push the build was successful
Details

@nickvergessen nickvergessen deleted the feature/noid/rich-messages branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment