Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and filter share that can't be found #70

Merged
merged 1 commit into from Apr 24, 2019

Conversation

@ChristophWurst
Copy link
Member

commented Apr 24, 2019

Fixes #69

Catches $userFolder->get($share->getTarget()) throwing a NotFoundException.

I could not reproduce the original issue, so this is untested. @lars-becker @jospoortvliet please test the patch

Catch and filter share that can't be found
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Apr 24, 2019

@ChristophWurst ChristophWurst self-assigned this Apr 24, 2019

@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation Apr 24, 2019

@rullzer rullzer referenced this pull request Apr 24, 2019

Merged

16.0.0 Final #15202

Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Apr 24, 2019

@rullzer
Copy link
Member

left a comment

Right. Yes this can happen.

@ChristophWurst ChristophWurst merged commit 46e79e4 into master Apr 24, 2019

3 checks passed

DCO DCO
Details
Travis CI - Pull Request Build Passed
Details
fixupbot No fixup commits found. The commit history is clean 👍
Details

Christoph's Tasks automation moved this from TO INTEGRATE to DONE Apr 24, 2019

@ChristophWurst ChristophWurst deleted the fix/filter-notfound-shares branch Apr 24, 2019

@lars-becker

This comment has been minimized.

Copy link

commented Apr 24, 2019

@ChristophWurst I tested the patch with RC2 and I can confirm that recommendations now work as they should. Thank you!

@ChristophWurst

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

/backport to stable16

@backportbot-nextcloud

This comment has been minimized.

Copy link

commented May 21, 2019

backport to stable16 in #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.