Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to limit wopi requests to specific source hosts #1640

Merged
merged 1 commit into from Jun 29, 2021

Conversation

juliushaertl
Copy link
Member

This PR adds a dedicated allow list that if specified will limit the hosts that can perform requests against the WOPI endpoints. IP parsing and subnet matching was taken from https://github.com/nextcloud/limit_login_to_ip/blob/master/lib/LoginHookListener.php

@juliushaertl juliushaertl added the 3. to review Ready to be reviewed label Jun 29, 2021
@juliushaertl
Copy link
Member Author

/backport to stable3.8

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl force-pushed the bugfix/noid/groupfolder-share branch from 6c6496a to bb8daed Compare June 29, 2021 16:24
@juliushaertl juliushaertl merged commit 2ea6350 into master Jun 29, 2021
27 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/groupfolder-share branch June 29, 2021 17:03
Copy link

@abdulmge abdulmge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants