Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen for event during preview rendering and apply secure view options #2579

Merged
merged 2 commits into from Oct 26, 2022

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 25, 2022

Summary

  • Refactor watermark (secure view) checks to actually check against the node/share permissions
  • Add option to enforce watermarks on disabled download shares (internal)
  • Add listener to disable previews of hide download share links
  • Clarify what secure view does in the settings (see screenshot)

Screenshot 2022-10-26 at 16 19 43

@juliushaertl juliushaertl force-pushed the bugfix/watermark-preview branch 3 times, most recently from 0c1eaa2 to 4970eb1 Compare October 26, 2022 11:57
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…me infos

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Oct 26, 2022
Copy link
Contributor

@Raudius Raudius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Only thing I noticed is that you close a read-only watermarked file, you get a pretty bare view.

Screenshot:

image

Might be something to look into with the design team after this PR is merged :)

@juliushaertl
Copy link
Member Author

Let me actually have a look at that, because closing is something we can probably disable in the collabora view :)

@juliushaertl
Copy link
Member Author

Might need some extra backend handling to hand over if we are on a single or folder share, will open a follow up issue for that.

@juliushaertl juliushaertl merged commit d03fa73 into master Oct 26, 2022
29 checks passed
@juliushaertl juliushaertl deleted the bugfix/watermark-preview branch October 26, 2022 19:51
@juliushaertl
Copy link
Member Author

/backport to stable25

@juliushaertl
Copy link
Member Author

/backport to stable24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants