diff --git a/apps/dav/appinfo/info.xml b/apps/dav/appinfo/info.xml index 19b65d84327e6..14849b714a790 100644 --- a/apps/dav/appinfo/info.xml +++ b/apps/dav/appinfo/info.xml @@ -23,6 +23,7 @@ OCA\DAV\Migration\Classification + OCA\DAV\Migration\FixBirthdayCalendarComponent OCA\DAV\Migration\GenerateBirthdays diff --git a/apps/dav/lib/CalDAV/BirthdayService.php b/apps/dav/lib/CalDAV/BirthdayService.php index ab2794e67dbab..71f4940a2c81f 100644 --- a/apps/dav/lib/CalDAV/BirthdayService.php +++ b/apps/dav/lib/CalDAV/BirthdayService.php @@ -116,6 +116,7 @@ public function ensureCalendarExists($principal) { $this->calDavBackEnd->createCalendar($principal, self::BIRTHDAY_CALENDAR_URI, [ '{DAV:}displayname' => 'Contact birthdays', '{http://apple.com/ns/ical/}calendar-color' => '#FFFFCA', + 'components' => 'VEVENT', ]); return $this->calDavBackEnd->getCalendarByUri($principal, self::BIRTHDAY_CALENDAR_URI); diff --git a/apps/dav/lib/Migration/FixBirthdayCalendarComponent.php b/apps/dav/lib/Migration/FixBirthdayCalendarComponent.php new file mode 100644 index 0000000000000..03bd298ff1d4d --- /dev/null +++ b/apps/dav/lib/Migration/FixBirthdayCalendarComponent.php @@ -0,0 +1,62 @@ + + * + * @copyright Copyright (c) 2016, ownCloud GmbH. + * @license AGPL-3.0 + * + * This code is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License, version 3, + * as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License, version 3, + * along with this program. If not, see + * + */ + +namespace OCA\DAV\Migration; + +use OCA\DAV\CalDAV\BirthdayService; +use OCP\IDBConnection; +use OCP\Migration\IOutput; +use OCP\Migration\IRepairStep; + +class FixBirthdayCalendarComponent implements IRepairStep { + + /** @var IDBConnection */ + private $connection; + + /** + * FixBirthdayCalendarComponent constructor. + * + * @param IDBConnection $connection + */ + public function __construct(IDBConnection $connection) { + $this->connection = $connection; + } + + /** + * @inheritdoc + */ + public function getName() { + return 'Fix component of birthday calendars'; + } + + /** + * @inheritdoc + */ + public function run(IOutput $output) { + $query = $this->connection->getQueryBuilder(); + $updated = $query->update('calendars') + ->set('components', $query->createNamedParameter('VEVENT')) + ->where($query->expr()->eq('uri', $query->createNamedParameter(BirthdayService::BIRTHDAY_CALENDAR_URI))) + ->execute(); + + $output->info("$updated birthday calendars updated."); + } +} diff --git a/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php b/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php index 33968ec242d56..7c772184fefe6 100644 --- a/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php +++ b/apps/dav/tests/unit/CardDAV/BirthdayServiceTest.php @@ -182,6 +182,17 @@ public function testGetAllAffectedPrincipals() { ], $users); } + public function testBirthdayCalendarHasComponentEvent() { + $this->calDav->expects($this->once()) + ->method('createCalendar') + ->with('principal001', 'contact_birthdays', [ + '{DAV:}displayname' => 'Contact birthdays', + '{http://apple.com/ns/ical/}calendar-color' => '#FFFFCA', + 'components' => 'VEVENT', + ]); + $this->service->ensureCalendarExists('principal001'); + } + public function providesBirthday() { return [ [true,