Skip to content
Permalink
Browse files

Do not allow to delete/update group shares as a group member

  • Loading branch information...
nickvergessen committed Jul 28, 2016
1 parent 482a725 commit 7289cb5ec0b812992ab0dfb889744b94bc0994f0
Showing with 4 additions and 4 deletions.
  1. +4 −4 apps/files_sharing/lib/API/Share20OCS.php
@@ -224,7 +224,7 @@ public function deleteShare($id) {
return new \OC_OCS_Result(null, 404, 'could not delete share');
}
if (!$this->canAccessShare($share)) {
if (!$this->canAccessShare($share, false)) {
$share->getNode()->unlock(ILockingProvider::LOCK_SHARED);
return new \OC_OCS_Result(null, 404, $this->l->t('Could not delete share'));
}
@@ -573,7 +573,7 @@ public function updateShare($id) {
$share->getNode()->lock(\OCP\Lock\ILockingProvider::LOCK_SHARED);
if (!$this->canAccessShare($share)) {
if (!$this->canAccessShare($share, false)) {
$share->getNode()->unlock(ILockingProvider::LOCK_SHARED);
return new \OC_OCS_Result(null, 404, $this->l->t('Wrong share ID, share doesn\'t exist'));
}
@@ -703,7 +703,7 @@ public function updateShare($id) {
* @param \OCP\Share\IShare $share
* @return bool
*/
protected function canAccessShare(\OCP\Share\IShare $share) {
protected function canAccessShare(\OCP\Share\IShare $share, $checkGroups = true) {
// A file with permissions 0 can't be accessed by us. So Don't show it
if ($share->getPermissions() === 0) {
return false;
@@ -722,7 +722,7 @@ protected function canAccessShare(\OCP\Share\IShare $share) {
return true;
}
if ($share->getShareType() === \OCP\Share::SHARE_TYPE_GROUP) {
if ($checkGroups && $share->getShareType() === \OCP\Share::SHARE_TYPE_GROUP) {
$sharedWith = $this->groupManager->get($share->getSharedWith());
if ($sharedWith->inGroup($this->currentUser)) {
return true;

0 comments on commit 7289cb5

Please sign in to comment.
You can’t perform that action at this time.