Skip to content
Permalink
Browse files

Don't print exception message in HTML

The exception message is potentially influenced by user input and could thus be confusing (e.g. somebody could try to open a file like "Please send a mail to support@foo.com", and then the message would include that string.

It is thus reasonable to not show the exception message by default. Also for the browser view I added an `exit()` at the end, as otherwise the XML exception would be attached.
  • Loading branch information...
LukasReschke committed Sep 9, 2016
1 parent 36c5547 commit a4cfb3ddc1f4cdb585e05c0e9b2f8e52a0e2ee3e
Showing with 3 additions and 5 deletions.
  1. +3 −4 apps/dav/lib/files/browsererrorpageplugin.php
  2. +0 −1 apps/dav/templates/exception.php
@@ -31,7 +31,6 @@
use Sabre\DAV\ServerPlugin;
class BrowserErrorPagePlugin extends ServerPlugin {
/** @var Server */
private $server;
@@ -88,8 +87,7 @@ public function logException(\Exception $ex) {
/**
* @codeCoverageIgnore
* @param \Exception $ex
* @param int $httpCode
* @param \Exception $exception
* @return bool|string
*/
public function generateBody(\Exception $exception) {
@@ -109,10 +107,11 @@ public function generateBody(\Exception $exception) {
return $content->fetchPage();
}
/*
/**
* @codeCoverageIgnore
*/
public function sendResponse() {
$this->server->sapi->sendResponse($this->server->httpResponse);
exit();
}
}
@@ -6,7 +6,6 @@
?>
<span class="error error-wide">
<h2><strong><?php p($_['title']) ?></strong></h2>
<p><?php p($_['message']) ?></p>
<br>

<h2><strong><?php p($l->t('Technical details')) ?></strong></h2>

0 comments on commit a4cfb3d

Please sign in to comment.
You can’t perform that action at this time.