Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextcloud logo not visible when theming color is white #10684

Closed
jancborchardt opened this issue Aug 14, 2018 · 12 comments
Closed

Nextcloud logo not visible when theming color is white #10684

jancborchardt opened this issue Aug 14, 2018 · 12 comments
Assignees
Labels
bug design Design, UI, UX, etc.

Comments

@jancborchardt
Copy link
Member

See:
screenshot from 2018-08-14 13-20-53

I would even say to invert the color of the Nextcloud logo as soon as the other header icons are inverted to keep everything looking nice and consistent. What do you think @nextcloud/designers @nextcloud/theming?

@jancborchardt jancborchardt added bug design Design, UI, UX, etc. labels Aug 14, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #8695 ([BUG] Clean Nextcloud Install No Logos or Theming), #5650 (Themed favicons don't visible if white theme color), #9274 (I can't change my nextcloud logo !), #5654 (Checkboxes don't work if white theming color), and #212 (Create themes vor nextcloud).

@jancborchardt
Copy link
Member Author

Same on the redirect page actually, with logo not being visible and header (but not main text) being white:
screenshot from 2018-08-14 13-28-23

@juliushaertl
Copy link
Member

We had some discussion about that in the past, and the conclusion was that we don't want to invert the logo, because the Nextcloud logo should either be blue or white. I don't have a strong opinion on this, but if you use theming you'll probably also replace the logo, so I don't think it is really an issue.

@skjnldsv
Copy link
Member

@juliushaertl can we use the svg api for the logo?

@weeman1337
Copy link
Member

the Nextcloud logo should either be blue or white

What about switching the logo to NC-blue at the same point the icons are inverted?

can we use the svg api for the logo?

As far as I understand the routes it's only possible to address files in core/img subdirectories. It needs an extension, since the logo is located directly in img.

@skjnldsv
Copy link
Member

We could move the logo to img though ^^

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 20, 2018

We had some discussion about that in the past, and the conclusion was that we don't want to invert the logo, because the Nextcloud logo should either be blue or white. I don't have a strong opinion on this, but if you use theming you'll probably also replace the logo, so I don't think it is really an issue.

I also don't like this special case. If you want a white nextcloud, then also upload an updated logo. Altering the logo only if it is the Nextcloud logo adds quite some logic for not too many use cases IMO. We should focus on real problems and not such artificial ones.

@MariusBluem
Copy link
Member

I agree with @MorrisJobke 👍

What we could do is forcing a different logo, name etc. or a explicit confirmation from admin since changing name, background etc. could violate the trademark guidelines of Nextcloud.

@MariusBluem
Copy link
Member

Besides that: white Nextcloud with blue-logo would look awesome 😍

@MorrisJobke
Copy link
Member

Besides that: white Nextcloud with blue-logo would look awesome 😍

But then I already see the issue with "I don't want it blue but $COLOR" -.-'

@weeman1337
Copy link
Member

I think this is more for the out of the box experience. If you change the color to a light one, the app icons change. Why not change the default logo also?

If an user uploads a custom logo it's up to him to align it with the color.

@juliushaertl
Copy link
Member

I think this is more for the out of the box experience. If you change the color to a light one, the app icons change. Why not change the default logo also?

Yes, I think for having a nice experience it would make sense to just have a blue logo for white colors. 👍

But then I already see the issue with "I don't want it blue but $COLOR" -.-'

As @weeman1337 said, they can still upload one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design Design, UI, UX, etc.
Projects
None yet
Development

No branches or pull requests

7 participants