Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Nextcloud 16 (alpha 1) polishing review #14639

Closed
jancborchardt opened this issue Mar 12, 2019 · 19 comments

Comments

Projects
None yet
10 participants
@jancborchardt
Copy link
Member

commented Mar 12, 2019

As usual, we test the daily zip file to find details for polishing. 🎉

Anyone is welcome to take over issues and help out! :)

👩‍🏭 Installation

  • Database toggle is completely broken #14643
  • "Storage & database " has space at the end #14643
  • Database password visibility toggle not toggleable via space (works for admin password) #14833
  • Highlight on "Finish setup" button is insufficient

🧙 First run wizard

  • Improve layout & design of "Principles" (page 2): maybe move icons to left and show as list
  • Improve layout & design of "Apps" (page 3): more zoomed app store screenshot so things are visible, reduce text
  • Settings section Mobile & desktop: Layout is broken, icon alignment in buttons nextcloud/firstrunwizard#175

📁 Files

  • Uploading a file, then changing to "Recent" and then changing to "All files" results in the cancel X of the upload progress to be next to the upload icon #15317
  • When deleting a file, the upload progress bar appears on the top
  • Grid view: Share action needs to be put into menu
  • Grid view: Select should be put into menu not 16
  • Grid view: In deleted files, Restore button is glitched inside of name, should be in the menu (only in grid view) #14931
  • Shares category: When going to details of a file, actions are duplicated
  • Deleted files: Thumbnails are low resolution #14719
  • Deleted files: action should say "Delete permanently" instead of just "Delete" #14721
  • Hovering filename in sidebar should show tooltip with full name (regression?)
  • Tapping filename in sidebar should show tooltip too for mobile
  • Highlight in sharing dialog (jQuery autocomplete) shouldn’t have the top and bottom border additionally
  • Titles of share pages are not specific #11506 to 17

🔮 Recommendations

🖼 Viewer

  • Content should be displayed bigger (currently Gallery shows it as big as possible, and Viewer shows them a bit small) nextcloud/viewer#21
  • Sometimes background flickers when changing images
  • Background tinting should be darker nextcloud/nextcloud-vue#300
  • Control hiding needs a quick fade out animation
  • Viewer app needs to take precedence over Gallery slideshow, also on public share page nextcloud/viewer#3
  • "Next" button shouldn’t be primary blue, takes too much attention from the images nextcloud/nextcloud-vue#275
  • Next & Previous buttons should be further to the sides, to be flush with X exit icon and not take focus away from the content
  • Unicode characters (e.g. japanese) in filename not correctly displayed when going through slideshow
  • Share and More icons should be on the right of the filename, not sticky to the X icon on the right
  • Simplify error message to "Error loading filename.svg" nextcloud/viewer#24
  • There’s a scrollbar on the right scrolling the content

⚡ Activity

🔎 Search

  • In grid view, results from other folders overlap summary of current folder contents ("3 files match …")
  • No grid view for search results from other folders.

🔔 Notifications

  • Dismissing older notification also hides every newer notification (only until refresh)
  • Notifications window should have min-height (same as when it’s empty)
  • Needs short compress animation for dismissing for proper feedback
    Moved to nextcloud/notifications#300

⚙ Settings

  • Text links not properly highlighted
  • Checkboxes (e.g. in "Sharing" or "Activity" settings) not properly highlighted on tabbing through
  • Personal info: Saving feedback needs to be faster
  • Personal info: Federation scope menu toggle not selectable via keyboard #14808
  • Accessibility: theme doesn’t change on tabbing to setting and activating it via space #14809
  • Admin overview: Update channel not reachable via keyboard, blue bar hover/focus feedback missing in entries #14809
  • Support: Add section about copying system report
  • Security → Two-Factor Authentication: Hide whole block below "Enforce" checkbox until it’s checked #14713

🛠 Apps management

  • Loading takes long when network connection is slow. Should just already display local apps (to 17 requires major work)
  • Having detail sidebar open and scrolling all the way down in the app list moves the sidebar up
  • Not possible to open sidebar via tabbing, only "Disable" (or "Download and enable") buttons are tabbable
  • App bundles page shows "No apps found for your version" on the bottom (also in 15 stable)

👥 User management

  • Feedback spinner should be on the button instead of on the left (where you don’t look when pressing the button)
  • After adding a user, focus should jump to "Username" field to add another user #14810
  • When zoomed or adding more columns, select elements overlap

Help

  • Could use icons in the left navigation
  • If zoomed in, menu should be hidden behind hamburger menu

🎨 Theming #14885

  • Light theming color:
    • On error pages like "File not found"
    • "Forgot password?" on log in is light, should be dark
    • App name in header has boxy background
    • 3 dot icon in share link header is white, should be black
    • First run wizard "next" icon should be dark because the primary color is light nextcloud/firstrunwizard#182
  • Dark theme: "File not found" screen has dark icon, should be white
  • Basically all the content of the .body-login-container should always be white because the container background is dark (#body-login p rule for footer overwrites this, should be more specific)
@nickvergessen

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

⚡ Activity

  • File previews are too big, and filetype icons way too small. (Regression)

I noticed this too lately, however the activity app was not modified in a long time, so it seems some global CSS is causing this?

  • Emptycontent icons and text should reflect the category

See nextcloud/activity#322 (comment) Maybe I can finish it in the contributor week.

🔔 Notifications

  • Dismissing older notification also hides every newer notification (only until refresh)

This should be fixed in master 🤔 But I will check again.

  • Notifications window should have min-height (same as when it’s empty)

okidoki

  • Needs short compress animation for dismissing for proper feedback

Can a designer do this or tell me how? I guess it goes here and fade is not enough? https://github.com/nextcloud/notifications/blob/master/src/components/notification.vue#L110

@icewind1991

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

  • Database toggle is completely broken
  • "Storage & database " has space at the end

#14643

@Valdnet

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

🔔 Notifications

Dismissing older notification also hides every newer notification (only until refresh)
This should be fixed in master 🤔 But I will check again.

👏 finally, it will be fixed.

@MorrisJobke MorrisJobke added the design label Mar 15, 2019

rullzer added a commit to nextcloud/activity that referenced this issue Mar 16, 2019

Set proper activity class
For nextcloud/server#14639

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer added a commit that referenced this issue Mar 16, 2019

Use higher preview resolution in trashbin
For #14639

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

rullzer added a commit that referenced this issue Mar 16, 2019

Trashbin: Delete => Delete permanently
For #14639

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@MorrisJobke

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Feedback from @karlitschek:

  • PDFs can't be opened (neither in the new viewer nor in the existing pdf viewer) -> nextcloud/files_pdfviewer#124
  • the layout of the First Run Wizard is broken - next buttons are outside the wizard
  • There are some errors in the log by default. We should make sure that there is nothing in there in a plain setup.
  • shouldn’t the new configuration profiles be in the clients page in the settings somewhere?
  • the layout/spacing on the Client page is broken. The icons in the buttons need alignment and a bit more space above the buttons.

Screen Shot 2019-03-18 at 09 32 07

@MorrisJobke

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

  • the layout of the First Run Wizard is broken - next buttons are outside the wizard

@jancborchardt I would say, that the buttons should be either right next to the image border or towards the display edges as we thought during the hackweek already.

@jancborchardt

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2019

Right – the first run wizard is a bit different to the viewer. @skjnldsv how about for the "normal/medium" size (used by first run wizard) we put the controls closer to the modal, like it was before for the first run wizard?

@MorrisJobke

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Right – the first run wizard is a bit different to the viewer. @skjnldsv how about for the "normal/medium" size (used by first run wizard) we put the controls closer to the modal, like it was before for the first run wizard?

Sounds also good 👍

@skjnldsv

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@jancborchardt the firstrunwizard still uses the old primary layout.
I'll try to add something.

@ChristophWurst

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Database password visibility toggle not toggleable via space (works for admin password)

This is caused by ReferenceError: zxcvbn is not defined. As far as I debugged, the strengthify lib does just add a new script tag to the head but doesn't wait for the script to actually load. Hence this might sometimes work, sometimes it will just fail. I'm a bit puzzled why this hasn't been reported earlier as I don't see anything changed for nc16.

@nickvergessen

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Our JS is noe bundled and therefor continues faster?

@ChristophWurst

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

No, the setup and installation scripts are not bundled. I don't think the bundling makes a difference here.

@ChristophWurst

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

I get the exact same error on stable15.

@rcdailey

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Above the file listing in 16 is a horizontal row of "recent files". Is there a way to hide this view for all users? I do not want recent files showing in the Files tab. I go to Activity for that.

@rullzer

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Above the file listing in 16 is a horizontal row of "recent files". Is there a way to hide this view for all users? I do not want recent files showing in the Files tab. I go to Activity for that.

disable the recommendations app

@ChristophWurst

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

php occ app:disable recommendations is your friend :)

@rcdailey

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

Thanks, I was assuming it would be a setting not an app. That fixed it.

Another issue I'm noticing is that the "Shares" view does not show a list of files with active public share links (list is empty). In version 15, this worked fine (I was previously running v15). When I click the share links in an incognito browser, however, I'm able to download the files.

So the files are still shared, but they don't show up in the Shares view. Is this a bug?

@violoncelloCH

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

something to add here: #15160

@violoncelloCH

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

  • Uploading a file, then changing to "Recent" and then changing to "All files" results in the cancel X of the upload progress to be next to the upload icon

uploading is not needed... just switching to any different view than "All files" and then back to it triggers this X to appear

@jancborchardt

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

Closing this in favor of the Nextcloud 17 polishing list! #16076 :)

If you find more issues, please open separate reports for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.