Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Nextcloud 17 polishing list! #16076

Open
jancborchardt opened this issue Jun 25, 2019 · 9 comments

Comments

@jancborchardt
Copy link
Member

commented Jun 25, 2019

As usual, we test the daily zip file to find details for polishing. 🎉

Everyone should go over the issues and see where they can help out! 😊 Add your handle if you work on it, or relevant issues or pull requests.

Bold issues are especially important and should be fixed for the release!

🏗 Pre-installation

  • Zip file is huge!
    • Because of .map files? – they are not that big
    • viewer ships cypress (36.4MB): Should be removed in tomorrows daily
    • 3rdparty/aws/aws-sdk-php/src/data possibly not necessary (12.2MB) too risky, might be in use
  • Change name of "Nextcloud.mp4" to "Nextcloud intro.mp4" to fix the strange Viewer issue which accomodates for iOS live images → pull request at nextcloud/example-files#5

👩‍🏭 Installation

  • Finish button not visible on some screens – possibly sticky, or make warning wider
  • Missing loading feedback on installation, should have a spinner – it’s there, Safari just stops rendering
  • Security warning is not greyed out
  • Whitescreen on installation, no feedback was caused by fatal PHP error caused by the support app interface, fixed by @juliushaertl

🧙 First run wizard

  • First run wizard should have different viewer background opacity (less dark) @juliushaertl
  • Scrollbar shows @juliushaertl
  • Content should fit into box @juliushaertl
  • Container shouldn’t need to resize between slides, adjust content, fix height and width @juliushaertl
  • Button style difference too harsh, prev button should have slight white-ish background

📁 Files

  • Non default views: First entry is overlapped by header #16366
  • When switching views and back to "All files" again, the upload bar x shows #16137
  • If settings menu (bottom left) is open, show a border-top
  • In all views except "All files": Border around folder/files icons, should only be around images with preview #14849
  • Breadcrumbs ellipsis menu needs max-width and ellipsis of entries
  • In the "Shared" view and in "Recent", favorites indicator is not shown
  • Range selection with shift does not work
  • When all are checked, don’t show "Select file ranges"
  • Think about moving "Share current folder" icon out of breadcrumb but to the right
  • File list moving 1px vertically on select all (top border?) #16475
  • Action menu shadow broken in Safari @nextcloud/mac

🍔 Sidebar

  • Share link should not open menu automatically
  • Copy link directly when sharing with tooltip feedback "Share created & link copied"
  • ~Share link flow revisit → 18~
  • Fix outdated comment icon → pull request at #15881
  • Add to project second row has too much line height (test if it flows into 2 lines)

👥 Sharing

  • Fix placement of icon in public share page for audio files #16118

📄 PDF viewer

🔮 Recommendations

  • Max-width for entries, ellipsize
  • Recommendations are not quite flush left with the file list icons → pull request at #16084

🖼 Viewer

  • "Play" should be called "Start slideshow" nextcloud/nextcloud-vue#449 (+ integrate the next release)
  • Background color issue with Slideshow button
  • Possibly make the sidebar dark in picture viewer mode (not in Text app though)

🏷 Tags

  • If there’s tags, show autocomplete dropdown directly

⚡ Activity

  • .mp4 filetype uses non-existing "video-mp4.svg" as mimetype icon, but we only have "video.svg" and should use that #16095
  • Activity settings: Instead of "Stream" use setting for "Push notifications". Use icons for Mail and Phone. Just show everything in stream. 2-4 weeks task
  • If Calendar app is not installed, show "Install Calendar app" with link to apps mgmt in emptycontent view of "Calendar" in Activity stream
  • Creation "+" icon looks interactive, bit confusing. Maybe different icon, maybe not use color

🖼 Gallery

🔎 Search

  • Show "Results from other folders" as a bigger header before the other results
  • Fix left-alignment of other results (move slightly to right to be same position as list view)

🔔 Notifications

  • Put timestamp below message instead of on top right to not conflict with close x

👥 Contacts menu

  • We can add a button to "Install Contacts app" here #16104

⚙ Settings personal

  • Too much vertical whitespace between entries in "Personal settings"
  • Mobile & desktop settings: Check over wording of "Server address"
  • Accessibility settings: prevent checking both High contrast and Dark theme
  • Remove "(beta)" label from Dark theme?
  • Federated Cloud: Nice image or illustration and more info about what it does, compare https://nextcloud.com/federation/
  • Privacy: Add the icons of the user data manifesto
  • Privacy: Put country picker above world map, and directly highlight country when choosing
  • Privacy: Country highlight should be primary theming color instead of red nextcloud/privacy#179

⚙ Settings admin

  • Logging: Take care that there’s no errors on default installation
  • Overview: Make "Security scan" a button, and prefill current instance address
  • Overview: Version info i icon not vertically aligned correctly #16236
  • Basic settings: Cron settings alignment issues: info i not correctly vertically aligned, detail text of radio buttons should be flush with first line #16236
  • Groupware: Also text alignment issues, indent the subline to be flush with first line #16236
  • Security: Sort blocks like this: Password policy, 2FA, Encryption, OAuth #16147
  • Theming: Notification icon is not inverted immediately on bright color
  • "Saving" indicators flashes between loading and "Saved", loading should only be shown if saving takes longer than X ms
  • System: Look over the design ;))))
  • System: Network: show boxes next to each other so it doesn’t use as much space vertically

🛠 Apps management

  • Button to "Update all" is needed in "All apps" view
  • "No ratings" shows as 2.5 stars – should not show anything (also fixes issue of showing ratings for official apps) #16141
  • Apps with update should have the counter inside a primary color bubble for attention - #452
  • Sidebar has two x buttons on the top right - #16122
  • App bundles section shows "No apps found for your version" on the bottom
  • Spinner for "install" app should show inside button instead of above
  • Sidebar info for untested apps should not show the text about "Dependency: server version 15 or lower required" but instead a sentence like "This app has not yet been marked as compatible with this server version, but you can install it at your own risk."
  • Right-click app needs an "Official" label @ChristophWurst #16145

👥 User management

  • "Language" dropdowns in the list overlap with next colum entries like "Storage location" if they are enabled

Help

  • Add icons to the left sidebar
@jancborchardt

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

cc @nextcloud/designers @nextcloud/vue and everyone really – if you want to pick up anything from this, you’re most welcome! :)

@enoch85

This comment was marked as resolved.

Copy link
Member

commented Jun 25, 2019

Sorry, maybe a seperate issue but;

Viewer

  • Reinstate the delete trashcan button
@jancborchardt

This comment was marked as resolved.

Copy link
Member Author

commented Jun 25, 2019

@enoch85 this is for small quick polishing mainly. Can't judge the workload on that one but seems like it might better be a separate issue. :)

@enoch85

This comment was marked as resolved.

Copy link
Member

commented Jun 25, 2019

@ChristophWurst

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

* Because of .map files?

No. They are not that big. It's mainly Cypress in viewer that caused the jump.

@ChristophWurst

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

Missing loading feedback on installation, should have a spinner

It's there. But since we're submitting a form the new page is loaded and AFAIK Safari stops rendering in that case. That is the same issue as with the apps/settings menu.

$('.float-spinner').show(250);

@ChristophWurst

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Button to "Update all" is needed in "All apps" view

I'm afraid this isn't a simple fix but requries more afford. Hence it's not really polishing but a new feature.

rullzer added a commit that referenced this issue Jun 28, 2019

Move OAuth down in admin security settings
For #16076

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

@jancborchardt jancborchardt referenced this issue Jun 28, 2019

Closed

✨ Nextcloud 16 (alpha 1) polishing review #14639

39 of 62 tasks complete

@gary-kim gary-kim referenced this issue Jul 4, 2019

Merged

Fix alignment issues in admin settings #16236

3 of 3 tasks complete

GretaD added a commit that referenced this issue Jul 5, 2019

Remove beta from dark theme name ref #16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

skjnldsv added a commit that referenced this issue Jul 6, 2019

Remove beta from dark theme name ref #16076 (#16253)
Remove beta from dark theme name ref #16076

compagnon added a commit to compagnon/nextcloud-server that referenced this issue Jul 10, 2019

Move OAuth down in admin security settings
For nextcloud#16076

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>

compagnon added a commit to compagnon/nextcloud-server that referenced this issue Jul 10, 2019

Remove beta from dark theme name ref nextcloud#16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

compagnon added a commit to compagnon/nextcloud-server that referenced this issue Jul 10, 2019

Remove beta from dark theme name ref nextcloud#16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

GretaD added a commit that referenced this issue Jul 11, 2019

Fix filelist overlap with header ref #16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

GretaD added a commit that referenced this issue Jul 12, 2019

Fix filelist overlap with header ref #16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

GretaD added a commit that referenced this issue Jul 16, 2019

Add border-top to settings menu when its open ref #16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

GretaD added a commit that referenced this issue Jul 17, 2019

Add border-top to settings menu when its open ref #16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

GretaD added a commit that referenced this issue Jul 17, 2019

Add border-top to settings menu when its open ref #16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

@MorrisJobke MorrisJobke referenced this issue Jul 17, 2019

Merged

17.0.0 Beta 1 #16408

12 of 28 tasks complete

rullzer added a commit that referenced this issue Jul 18, 2019

Fix filelist overlap with header ref #16076
Signed-off-by: Greta Doci <gretadoci@gmail.com>

MorrisJobke added a commit that referenced this issue Jul 18, 2019

Merge pull request #16420 from nextcloud/bugfix/noid/settings-menu-bo…
…rder-top

 Add border-top to settings menu when its open ref #16076

MorrisJobke added a commit that referenced this issue Jul 18, 2019

weeman1337 added a commit that referenced this issue Jul 20, 2019

@Thatoo

This comment was marked as off-topic.

Copy link

commented Jul 26, 2019

Would it be possible to get an an API that fully, properly and easily manage mimetypes?
#9192
Usability of some apps are reduced by lack of it.
For example Keeweb is not click&play because .kdbx are not recognized by nextcloud and when we click on our keepass database, it invites us to download it instead of opening Keeweb.

@skjnldsv

This comment was marked as off-topic.

Copy link
Member

commented Jul 26, 2019

@Thatoo this is not the issue to ask questions :)
As you mentioned, #9192 is the issue to discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.