Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External SMB/CIFS Broken on 17.0.1 #17846

Closed
cyberfarer opened this issue Nov 7, 2019 · 13 comments · Fixed by #17873

Comments

@cyberfarer
Copy link

@cyberfarer cyberfarer commented Nov 7, 2019

After upgrading to 17.0.1 Beta, I am no longer able to add External SMB/CIFS storage. Existing storage remains available to users.

Steps to reproduce

  1. Update to 17.0.1 Beta
  2. Add SMB/CIFS external storage

Expected behaviour

When correct information is added, a green check mark should appear to the left of the entry. The storage should be available via frontend.

Actual behaviour

Red exclamation mark appears and storage is not saved nor available.

Server configuration

Operating system:
Ubuntu 18.04 LTS

Web server:
Apache 2.4.29

Database:
MySQL 5.7

PHP version:
7.2.24

Nextcloud version: (see Nextcloud admin page)
17.0.1 Beta

Updated from an older Nextcloud/ownCloud or fresh install:
Updated from 17

I have reverted back to 17 from a snapshot.

@kesselb

This comment has been minimized.

Copy link
Contributor

@kesselb kesselb commented Nov 7, 2019

Something in the logs?

@kesselb kesselb added the needs info label Nov 7, 2019
@cyberfarer

This comment has been minimized.

Copy link
Author

@cyberfarer cyberfarer commented Nov 7, 2019

Unfortunately, no and I did enable debugging. I also removed php-smbclient but no change.

@rawrspace

This comment has been minimized.

Copy link

@rawrspace rawrspace commented Nov 8, 2019

I am also getting this error in 17.0.1 Beta

The network call to save the external storage returns a 422 with the response of
{"message":"Unsatisfied backend parameters"}

Request was

{
    "mountPoint": "FolderInNC",
    "backend": "smb",
    "authMechanism": "password::password",
    "backendOptions": {
        "host": "192.168.0.25",
        "share": "ShareName",
        "root": "FolderInShare",
        "domain": "",
        "show_hidden": false,
        "timeout": "",
        "user": "user",
        "password": "password"
    },
    "testOnly": true,
    "mountOptions": {
        "encrypt": true,
        "previews": true,
        "enable_sharing": false,
        "filesystem_check_changes": 1,
        "encoding_compatibility": false,
        "readonly": false
    }
}
@kesselb

This comment has been minimized.

Copy link
Contributor

@kesselb kesselb commented Nov 8, 2019

(new DefinitionParameter('timeout', $l->t('Timeout')))
->setType(DefinitionParameter::VALUE_HIDDEN)

Does it work again if you change the above code to?

    (new DefinitionParameter('timeout', $l->t('Timeout')))
        ->setType(DefinitionParameter::VALUE_HIDDEN)
        ->setFlag(DefinitionParameter::FLAG_OPTIONAL) 

Edit: Fixed the wrong comma.

@rawrspace

This comment has been minimized.

Copy link

@rawrspace rawrspace commented Nov 8, 2019

@kesselb There is a slight typo in what you provided with the comma position but I can confirm that it resolved the issue to use the following;

(new DefinitionParameter('timeout', $l->t('Timeout')))      
                ->setType(DefinitionParameter::VALUE_HIDDEN)                
                ->setFlag(DefinitionParameter::FLAG_OPTIONAL),
@spiezmaestro

This comment has been minimized.

Copy link

@spiezmaestro spiezmaestro commented Nov 9, 2019

Had the same issue (17.0.1 RC) and can confirm, that changing the code as suggested (with the correct comma position as noted by rawrspace) fixed it. Can change/add SMB shares again.

@scanom

This comment has been minimized.

Copy link

@scanom scanom commented Nov 11, 2019

Same issue happening with 16.0.6, patch solves it.

@e-alfred

This comment has been minimized.

Copy link

@e-alfred e-alfred commented Nov 11, 2019

Anyone pushing a PR to get this fix into the codebase?

@southeasterntech

This comment has been minimized.

Copy link

@southeasterntech southeasterntech commented Nov 12, 2019

I can confirm that this solution does work and the issue is still present in 17.01 stable.

@kesselb kesselb changed the title External SMB/CIFS Broken on 17.0.1 Beta External SMB/CIFS Broken on 17.0.1 Nov 13, 2019
@scanom

This comment has been minimized.

Copy link

@scanom scanom commented Nov 13, 2019

Only saw the backport to stable17, but patch is needed also for 16 at least, isn’t it?

@mamatt mamatt unpinned this issue Nov 18, 2019
@ikerib

This comment has been minimized.

Copy link

@ikerib ikerib commented Nov 19, 2019

We are having this issue after upgrading to version 17.0.1. The external storage that was present on version 16 works but we can't create new ones

@kesselb

This comment has been minimized.

Copy link
Contributor

@kesselb kesselb commented Nov 26, 2019

Please keep this pinned until 17.0.2 and 16.0.7 are released.

@florian-obradovic

This comment has been minimized.

Copy link

@florian-obradovic florian-obradovic commented Nov 29, 2019

Same here:
"We are having this issue after upgrading to version 17.0.1. The external storage that was present on version 16 works but we can't create new ones"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.