Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments within a federated share should be made visible to all federated parties #2197

Open
didierm opened this issue Nov 18, 2016 · 4 comments

Comments

@didierm
Copy link

commented Nov 18, 2016

In the context of a (federated) share, we consider comments as a valuable means of communication and hence an essential part of the collaboration effort.

While we appreciate use cases where tags are being contained to the server where they are initially created and stored, we deem it appropriate to make comments within a federated share available to all parties having access to that share.

Steps to reproduce

  1. For collaboration purposes, UserA federates a share (shareX) on serverA to UserB on ServerB ;
  2. UserA creates comments in the shareX realm ;
  3. UserB creates comments in the shareX realm.

Expected behaviour

Parties with access to shareX (i.e. both UserA and UserB) should see all comments in this share's realm.

Actual behaviour

UserA only sees his/her own shareX comments (stored on ServerA), UserB only sees his/her own shareX comments (stored on ServerB).

Server configuration

Nextcloud version: 10.0.1

Workflow proposal :

  • Add a 'public/private' boolean field to table oc_comments (defaulting to private) ;

  • When a share is federated, disclose a [public] checkbox next to the [Post] button in the UI, allowing (new) comments to be made public ;

  • For performance and privacy reasons, comments which are tagged public are stored in or transferred to table oc_comments on the server hosting the share, private comments are stored on or transferred to the user's server;

  • Reversal from public to private status and vice versa can only be executed by the comment owner [oc_comments.actor_id].

@jancborchardt

This comment has been minimized.

Copy link
Member

commented Feb 21, 2017

Comments should simply work for federated shares. No need for a private/public switch (that would only be for shared links, see #2019).

cc @blizzz @schiessle

@blizzz

This comment has been minimized.

Copy link
Member

commented Mar 7, 2017

We had this discussion some time ago, that sometimes you want to have comments available to any recipients, but sometimes only internal (e.g. when sharing to a partner or customer while having comments with sensitive content). I don't think we had a good idea to solve this back then.

@jancborchardt jancborchardt added the design label Mar 8, 2017

@MorrisJobke MorrisJobke removed this from the Nextcloud 12.0 milestone Apr 30, 2017

@sunjam

This comment has been minimized.

Copy link

commented Apr 25, 2018

So there is no way to comment with another federated user about your shared files? ☹️

@blizzz

This comment has been minimized.

Copy link
Member

commented Apr 25, 2018

@sunjam currently, no

@schiessle weren't you drafting a masterplan for federation advancements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
You can’t perform that action at this time.