Disabled appstore in config.php still access the store #2959

Open
Gomez opened this Issue Jan 5, 2017 · 2 comments

Projects

None yet

2 participants

@Gomez
Member
Gomez commented Jan 5, 2017

Steps to reproduce

  1. Add 'appstoreenabled' => false to config.php
  2. Access https://cloudurl.com/settings/apps

Expected behaviour

Only apps that exits on the filesystem should be installable. No other category than "Enabled" and "Not enabled" should be shown. (Like in Nextcloud 10)

Actual behaviour

Many categories are shown like Files, Multimedia ...
All Apps from the store are shown.

Server configuration

Nextcloud version: (see Nextcloud admin page)
Version 11.0.0 (git)

Updated from an older Nextcloud/ownCloud or fresh install:
Fresh

Where did you install Nextcloud from:
GIT

@Gomez Gomez added the bug label Jan 5, 2017
@Gomez
Member
Gomez commented Jan 5, 2017

Related #2701

@Gomez
Member
Gomez commented Jan 14, 2017

Thanks to @nickvergessen just a "return [];" in https://github.com/nextcloud/server/blob/master/lib/private/App/AppStore/Fetcher/Fetcher.php#L97 solves it.

I will create a proper PR.

@Gomez Gomez was assigned by nickvergessen Jan 16, 2017
@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment