New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope of the contacts menu is too broad #5097

Open
DanScharon opened this Issue May 24, 2017 · 13 comments

Comments

Projects
None yet
10 participants
@DanScharon
Copy link

DanScharon commented May 24, 2017

For a Nextcloud instance with a lot of users (e.g. from a user directory like LDAP) the scope of the contacts menu may seem way too broad as on first click it tries to load all users of that instance and shows the first 25 entries instead of just real "contacts".
This may take a long while depending on the LDAP connection and within an organization of >10.000 users the first 25 alphabetically sorted users may just seem random people, not contacts.
This behaviour might also be especially confusing when the contacts app is not enabled.

So it would be great if there was a way to disable the contacts menu or alternatively to at least limit it to users I really had interactions with, like file sharing or adding to the buddy list of the chat app, etc.

@Spartachetto

This comment has been minimized.

Copy link

Spartachetto commented May 25, 2017

I think this is a duplicate of #4656

@joergmschulz

This comment has been minimized.

Copy link

joergmschulz commented May 26, 2017

Well, no duplicate because the quoted issue is closed already / there has been the pledge to open a separate issue.
In my opinion, the users that appear on the contacts screen should be limited to the users who share the [ldap|local|whateve auth engine is applied] groups of the current user PLUS all contacts in the user's address books.

@jancborchardt

This comment has been minimized.

Copy link
Member

jancborchardt commented May 30, 2017

Yeah, of course we need some means to show the most relevant contacts first. As described in the spec #207:

The contacts are sorted by last interaction. It’s easiest and most obvious for the first iteration. (Instead of also factoring in frequency etc)

cc @ChristophWurst @nextcloud/javascript @nextcloud/chat :)

@GitHubUser4234

This comment has been minimized.

Copy link
Contributor

GitHubUser4234 commented Jun 27, 2017

image

When this option is enabled, users NOT in the same group and NOT in the address book should never be displayed.

Doesn't look hard to implement, as the logic for the sharing pulldown could be used as filter.

Until then, no other way than hacking the source code 😕

@DanScharon

This comment has been minimized.

Copy link
Author

DanScharon commented Jun 27, 2017

When this option is enabled, users NOT in the same group and NOT in the address book should never be displayed.

@GitHubUser4234 that option is irrelevant for the environment I described. There the address book is disabled and users should be able to share outside of their groups. And still the current scope of the contacts menu is too broad.

@GitHubUser4234

This comment has been minimized.

Copy link
Contributor

GitHubUser4234 commented Jun 27, 2017

@DanScharon I see, well, my reply was referring more to @joergmschulz's comment. So we do have somewhat different requirements, but it looks like simply offering to disable the contact list could serve as common ground.

@jancborchardt

This comment has been minimized.

Copy link
Member

jancborchardt commented Jun 28, 2017

@GitHubUser4234 as far as I know this has been fixed. Cc @ChristophWurst @MorrisJobke for comment.

@DanScharon please see my comment. The spec intends better focus and it's a matter of time and resources to implement it.

@GitHubUser4234

This comment has been minimized.

Copy link
Contributor

GitHubUser4234 commented Jun 29, 2017

@jancborchardt Is it? I thought that currently it can only be disabled when autocompletion in share dialog is disabled (#4656)? Sure I'll be happy to be proven wrong 😸

@sananirajabov

This comment has been minimized.

Copy link

sananirajabov commented Dec 13, 2018

Hi, is someone working on this issue?

@nextcloud-bot nextcloud-bot removed the stale label Dec 13, 2018

@skjnldsv

This comment has been minimized.

Copy link
Member

skjnldsv commented Dec 14, 2018

@sananirajabov not that I'm aware of :)

@sananirajabov

This comment has been minimized.

Copy link

sananirajabov commented Dec 14, 2018

@skjnldsv perfect :)

@muppeth

This comment has been minimized.

Copy link

muppeth commented Dec 20, 2018

On top of all that if you want the users on the platform not to be able to autocomplete/see other users, disabling that option in sharing settings does not prevent leaks in other apps that do use system addressbook. Those like circles or calendars (when adding attendees) do autocomplete users and give suggestions in dropdown menu.

My current idea for a work around the issue is basically deleting all contacts from the system addressbook (from oc_cards_properties). I would like to know if this has any implication to the way things work. I checked file sharing, talk, calendar, contacts and seems like everything works properly (users cant see eachother using autocomplete suggestion but when typing the entire user name).
I would like to get rid of the issue asap, but would like some re-assuring that this will not back fire if i missed something.

Also in case this gets solved in the future, there is a way via occ to rebuild user addressbook. The problem is it fetches only 500 users from the db. Is there a way to do it for all users?

Edit:
Seems like you can't add users from nextlcoud as attendee of calendar event, unless user figures in personal addressbook.

@sananirajabov

This comment has been minimized.

Copy link

sananirajabov commented Jan 19, 2019

I have a question about searching users. Now, I limited users by sharing something with me, that's way now when I click to search users section just shared users appear, but when I search a user it only search in shared users because I retrieve users from database only who shared something with me. I think this implementation is right, but I am not sure. Could you share your opinions about this question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment