New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with contacts in the Menubar in NC12 with IE11 #5281

Closed
Stabre opened this Issue Jun 7, 2017 · 10 comments

Comments

@Stabre

Stabre commented Jun 7, 2017

Steps to reproduce

1.Open Webinterface on NC12 with Microsoft Internet Explorer 11
2. click on contacts in the right Conner of the menubar and the contacts are loaded
3.

Expected behaviour

Tell us what should happen

Actual behaviour

The Contacts reloaded every view seconds and the user is not able to select any contact
in Chrome and Mozilla there isn´t any reloading every view seconds

Server configuration

Operating system:
Debian 8

Web server:
Apache2
Database:
MariaDB
PHP version:
5.4
Nextcloud version: (see Nextcloud admin page)
12.0
Updated from an older Nextcloud/ownCloud or fresh install:
11.0
Where did you install Nextcloud from:
nextcloud.com
Signing status:

Signing status
Login as admin user into your Nextcloud and access 
http://bcloud.buerkle-gmbh.de/index.php/settings/integrity/failed 
paste the results here.
``
`No errors have been found.
</details>

**List of activated apps:**
<details>
<summary>App list</summary>

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

</details>

**Nextcloud configuration:**
<details>
<summary>Config report</summary>

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or

Insert your config.php content here.
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

</details>

**Are you using external storage, if yes which one:** local/smb/sftp/...

**Are you using encryption:** yes/no

**Are you using an external user-backend, if yes which one:** LDAP/ActiveDirectory/Webdav/...

#### LDAP configuration (delete this part if not used)
<details>
<summary>LDAP config</summary>

With access to your command line run e.g.:
sudo -u www-data php occ ldap:show-config
from within your Nextcloud installation folder

Without access to your command line download the data/owncloud.db to your local
computer or access your SQL server remotely and run the select query:
SELECT * FROM oc_appconfig WHERE appid = 'user_ldap';

Eventually replace sensitive data as the name/IP-address of your LDAP server or groups.

</details>

### Client configuration
**Browser:**

**Operating system:**

### Logs
#### Web server error log
<details>
<summary>Web server error log</summary>

Insert your webserver log here

</details>

#### Nextcloud log (data/nextcloud.log)
<details>
<summary>Nextcloud log</summary>

Insert your Nextcloud log here

</details>

#### Browser log
<details>
<summary>Browser log</summary>

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

</details>
@blizzz

This comment has been minimized.

Member

blizzz commented Jun 12, 2017

@blizzz

This comment has been minimized.

Member

blizzz commented Jun 12, 2017

and/or perhaps @nextcloud/contacts

@herrfeuer

This comment has been minimized.

herrfeuer commented Jul 4, 2017

I can confirm This Bug with NC12, IE11, nginx on Centos7.

@jacestk

This comment has been minimized.

jacestk commented Jul 24, 2017

same thing here with Centos7!
Someone can tell me what apps/modules is generating this list? I will try to patch it

@herrfeuer

This comment has been minimized.

herrfeuer commented Jul 24, 2017

@jacestk start searching in contactmenu.js. i tried to switch back to that version worked in nc11 but no success.

@jacestk

This comment has been minimized.

jacestk commented Jul 24, 2017

Yep thanx, found it after some reseach... line 296

_onSearch: _.debounce(function() {
			this.trigger('search', this.$('#contactsmenu-search').val());
		}, 700),

if you replace the timer value "700" by "5000" for example, the list appears but the research don't work anymore until the end of the time.
So the problem is from the trigger or _debounce function... Have to investigate a bit more...

@jacestk

This comment has been minimized.

jacestk commented Jul 25, 2017

here my awful patch:

	_onSearch: _.debounce(function(){
			if (this.fixie11 !== this.$('#contactsmenu-search').val() ) {
				this.fixie11 = this.$('#contactsmenu-search').val();
				this.trigger('search', this.$('#contactsmenu-search').val());
			}
		}, 700),

Another problem appears: the first time you click onto the contacts icon, the list is "empty" (only a empty div is sended). Still working on it

@blizzz

This comment has been minimized.

Member

blizzz commented Aug 29, 2017

@ChristophWurst mind having a look? ^

@ChristophWurst ChristophWurst self-assigned this Aug 29, 2017

@ChristophWurst ChristophWurst added this to SELECTED in Christoph's Tasks Sep 27, 2017

@ChristophWurst ChristophWurst moved this from SELECTED to IN PROGRESS (max 3 PRs) in Christoph's Tasks Oct 9, 2017

@ChristophWurst

This comment has been minimized.

Member

ChristophWurst commented Oct 9, 2017

Found it: we're focussing the input field after rending the list of contacts. Since IE11 apparently has a bug where it triggers the 'input' even whenever a input gets focus, this causes an endless loop. Looks like M$ doesn't care about the bug and it's not being fixed: https://connect.microsoft.com/IE/feedback/details/810538/ie-11-fires-input-event-on-focus

However, I think I can add a little fix to this. Won't be the best UX, but it will at least not keep reloading all the time …

ChristophWurst added a commit that referenced this issue Oct 9, 2017

Fix contacts menu for IE11
IE11 triggers an 'input' event whenever an input is focussed
or loses focus. Thus this causes an endless loading loop as soon
as the view is re-rendered. To prevent this, this remembers the
previous search term and ignores events where the term has not
changed.

Fixes #5281

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

@ChristophWurst ChristophWurst added this to the Nextcloud 13 milestone Oct 9, 2017

@ChristophWurst

This comment has been minimized.

Member

ChristophWurst commented Oct 9, 2017

Fix can be found at #6795

@ChristophWurst ChristophWurst moved this from IN PROGRESS (max 3 PRs) to TO REVIEW (max 4 PRs) in Christoph's Tasks Oct 10, 2017

@blizzz blizzz closed this in #6795 Oct 12, 2017

ChristophWurst added a commit that referenced this issue Oct 12, 2017

Fix contacts menu for IE11
IE11 triggers an 'input' event whenever an input is focussed
or loses focus. Thus this causes an endless loading loop as soon
as the view is re-rendered. To prevent this, this remembers the
previous search term and ignores events where the term has not
changed.

Fixes #5281

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

@ChristophWurst ChristophWurst moved this from TO REVIEW (max 4 PRs) to DONE in Christoph's Tasks Oct 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment