New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unspecified share exception" instead of proper 404 page on unknown public share tokens #5346

Closed
MorrisJobke opened this Issue Jun 12, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@MorrisJobke
Member

MorrisJobke commented Jun 12, 2017

  • open a public share page with a not available share token - like http://example.org/s/abcdef
  • expected: get a proper 404 page
  • actual: get a "Unspecified share exception"

bildschirmfoto 2017-06-12 um 11 18 12

Ideas when this came in?

@nextcloud/sharing @nickvergessen

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke
Member

MorrisJobke commented Jun 12, 2017

cc @oparoz

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0.1 milestone Jun 12, 2017

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen

nickvergessen Jun 13, 2017

Member

Yeah

throw new ShareNotFound();
}
try {
$share = $this->createShare($data);
} catch (InvalidShare $e) {
throw new ShareNotFound();
would need some dedicated message. Not sure why this was not done, but I guess there is no reason?

Member

nickvergessen commented Jun 13, 2017

Yeah

throw new ShareNotFound();
}
try {
$share = $this->createShare($data);
} catch (InvalidShare $e) {
throw new ShareNotFound();
would need some dedicated message. Not sure why this was not done, but I guess there is no reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment