Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12] set s3 part size to 500mb #6815

Merged
merged 1 commit into from Oct 15, 2017
Merged

Conversation

icewind1991
Copy link
Member

Instead of the default 5mb

Also sets the size cutoff where we start using multipart to 500mb

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Oct 11, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0.4 milestone Oct 11, 2017
@codecov
Copy link

codecov bot commented Oct 11, 2017

Codecov Report

Merging #6815 into stable12 will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@              Coverage Diff               @@
##             stable12    #6815      +/-   ##
==============================================
- Coverage       53.76%   53.76%   -0.01%     
  Complexity      22563    22563              
==============================================
  Files            1384     1384              
  Lines           86577    86579       +2     
  Branches         1328     1328              
==============================================
+ Hits            46546    46547       +1     
- Misses          40031    40032       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/S3ObjectTrait.php 59.18% <33.33%> (-0.4%) 11 <0> (ø)
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 84.8% <0%> (+0.12%) 121% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@rullzer rullzer merged commit d575577 into stable12 Oct 15, 2017
@rullzer rullzer deleted the s3-multipart-upload-part-size-12 branch October 15, 2017 19:41
@MorrisJobke MorrisJobke mentioned this pull request Nov 20, 2017
1 task
Copy link

@mateuszsocko mateuszsocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can i change the part size?
500mb is too much, we have errors connection time out...
Change that for 100mb..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants