New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] [LDAP] The WebUI Wizard also should not assign empty config IDs #10824

Merged
merged 1 commit into from Sep 13, 2018

Conversation

@blizzz
Member

blizzz commented Aug 23, 2018

backport of #10820

@MorrisJobke not so serious, feel free to move to 13.0.7. This should not be a blocker.

[LDAP] The WebUI Wizard also should not assign empty config IDs
With 689df9a the behaviour to assign only
non-empty config IDs was introduced. Only, this was only effective for CLI
and OCS API.

Related to #3270.

The web UI creates now also a full configuration on first load. This fixes
#5094.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Aug 24, 2018

RC 1 is out -> moving to 13.0.7

@blizzz

This comment has been minimized.

Member

blizzz commented Sep 3, 2018

failing tests not related

@blizzz

This comment has been minimized.

Member

blizzz commented Sep 12, 2018

reviews, pozhaluysta? 😸

@@ -49,6 +49,14 @@ public function __construct(IL10N $l) {
public function getForm() {
$helper = new Helper(\OC::$server->getConfig());
$prefixes = $helper->getServerConfigurationPrefixes();
if(count($prefixes) === 0) {

This comment has been minimized.

@nickvergessen

nickvergessen Sep 13, 2018

Member

Use empty in the future ;)

This comment has been minimized.

@blizzz

blizzz Sep 13, 2018

Member

it wouldn't be a big array in this case, still you're right.

@nickvergessen

🐘

@blizzz blizzz merged commit acce19f into stable13 Sep 13, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@blizzz blizzz deleted the backport/10820/stable13 branch Sep 13, 2018

This was referenced Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment