New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable13] Fix mimetype detection for junked uploads #10829

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@nickvergessen
Member

nickvergessen commented Aug 24, 2018

Backport #10828

Fix mimetype detection for junked uploads
Signed-off-by: Joas Schilling <coding@schilljs.com>
@rullzer

rullzer approved these changes Sep 5, 2018

@nickvergessen nickvergessen requested a review from blizzz Sep 5, 2018

@nickvergessen

This comment has been minimized.

Member

nickvergessen commented Sep 13, 2018

Second review please for this backport @blizzz @schiessle

@nickvergessen nickvergessen requested a review from schiessle Sep 13, 2018

$path = $this->request->getPathInfo();
$this->mimeType[$this->storage->getId()][$this->path] = $this->mimeTypeDetector->detectPath($path);
if ($this->request->getMethod() === 'PUT' || $this->request->getMethod() === 'MOVE') {
if ($this->request->getMethod() === 'MOVE') {

This comment has been minimized.

@blizzz

blizzz Sep 13, 2018

Member

could have been an elsif, less nesting, but OK

@blizzz

blizzz approved these changes Sep 13, 2018

🐘

@blizzz blizzz merged commit 9c68ce1 into stable13 Sep 13, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@blizzz blizzz deleted the backport/10828/mimetype-detection-broken-for-junked-uploads branch Sep 13, 2018

This was referenced Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment