New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] Improve performance when dealing with large numbers of shares #10884

Merged
merged 11 commits into from Sep 27, 2018

Conversation

Projects
None yet
3 participants
@icewind1991
Member

icewind1991 commented Aug 27, 2018

Backport of #10724

icewind1991 added some commits Aug 16, 2018

remove double loop for detecting changed mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
use more efficient method to find mountpoint for path
Signed-off-by: Robin Appelman <robin@icewind.nl>
cache OC\Files\Mount\Manager::findIn results
Signed-off-by: Robin Appelman <robin@icewind.nl>
cache OC\Files\Mount\Manager::findIn results
Signed-off-by: Robin Appelman <robin@icewind.nl>
more efficient unique share target generation
Signed-off-by: Robin Appelman <robin@icewind.nl>
more efficient way to detect added and removed mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
re-use view instances for shared storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
don't check if target dir exists when using the default share target …
…directory

Signed-off-by: Robin Appelman <robin@icewind.nl>
only determine is sharing is disabled for a user once
Signed-off-by: Robin Appelman <robin@icewind.nl>
tokens can't be valid local user names
this saves searching for shares on non-public link dav requests

Signed-off-by: Robin Appelman <robin@icewind.nl>
cache parent exists status during share setup
Signed-off-by: Robin Appelman <robin@icewind.nl>

@icewind1991 icewind1991 added this to the Nextcloud 13.0.7 milestone Aug 27, 2018

@icewind1991 icewind1991 requested review from rullzer and MorrisJobke Aug 27, 2018

@icewind1991 icewind1991 changed the title from [13] A dav plugin to allow pagination of multipart responses to [13] Improve performance when dealing with large numbers of shares Aug 27, 2018

@rullzer

rullzer approved these changes Sep 5, 2018

🐘

@MorrisJobke MorrisJobke merged commit 065ec74 into stable13 Sep 27, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the large-share-count-performance-13 branch Sep 27, 2018

This was referenced Oct 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment