New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Remove reading PATH_INFO from server variable #1104

Merged
merged 1 commit into from Aug 28, 2016

Conversation

Projects
None yet
3 participants
@LukasReschke
Member

LukasReschke commented Aug 27, 2016

Backport of #984, talked with @ChristophWurst about it today and not having this in stable10 causes problems with the TOTP app.

Remove reading PATH_INFO from server variable
Having two code paths for this is unreliable and can lead to bugs. Also, in some cases Apache isn't setting the PATH_INFO variable when mod_rewrite is used.

Fixes #983

@LukasReschke LukasReschke added this to the Nextcloud 10.0.1 milestone Aug 27, 2016

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Aug 28, 2016

Member

LGTM

Member

rullzer commented Aug 28, 2016

LGTM

@raghunayyar

This comment has been minimized.

Show comment
Hide comment
@raghunayyar

raghunayyar Aug 28, 2016

Member

The backport looks good. 👍

Member

raghunayyar commented Aug 28, 2016

The backport looks good. 👍

@raghunayyar raghunayyar merged commit af515a6 into stable10 Aug 28, 2016

4 checks passed

Scrutinizer No new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@raghunayyar raghunayyar deleted the stable10-backport-dont-read-server-variable branch Aug 28, 2016

strukturag-service pushed a commit to spreedbox-packaging/nextcloud-debian that referenced this pull request Sep 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment