New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] theming performance #1126

Merged
merged 2 commits into from Aug 29, 2016

Conversation

Projects
None yet
4 participants
@LukasReschke
Member

LukasReschke commented Aug 29, 2016

Backport of #1103 as per #1106 (comment)

LukasReschke added some commits Aug 27, 2016

Increase theming performance
1. Set proper caching headers (`Pragma: cache`)
2. Resize image proportionally to a max size of 1920px
3. Store images with progressive mode

This resizes a previous 2.8 MB picture to 300kb and makes it rendering going down from 11 seconds to less than 1 here. And future requests won't have to download the file newly.

@LukasReschke LukasReschke added this to the Nextcloud 10.0.1 milestone Aug 29, 2016

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 29, 2016

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @juliushaertl and @nickvergessen to be potential reviewers

mention-bot commented Aug 29, 2016

@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @juliushaertl and @nickvergessen to be potential reviewers

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Aug 29, 2016

Member

👍

Member

rullzer commented Aug 29, 2016

👍

fail: function (e, data){
OC.msg.finishedSaving('#theming_settings_msg', response);
fail: function (e, response){
OC.msg.finishedError('#theming_settings_msg', response._response.jqXHR.responseJSON.data.message);

This comment has been minimized.

@nickvergessen
@nickvergessen

nickvergessen Aug 29, 2016

Member

🙈

@nickvergessen

This comment has been minimized.

Show comment
Hide comment
@nickvergessen
Member

nickvergessen commented Aug 29, 2016

👍

@nickvergessen nickvergessen merged commit 167cea0 into stable10 Aug 29, 2016

4 checks passed

Scrutinizer 1 new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nickvergessen nickvergessen deleted the stable10-theming-performance branch Aug 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment