New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Fix contacts menu on mentions #11350

Merged
merged 2 commits into from Sep 26, 2018

Conversation

Projects
None yet
5 participants
@danxuliu
Member

danxuliu commented Sep 24, 2018

Backport of #11258

danxuliu added some commits Sep 15, 2018

Fix contacts menu not triggered on certain areas of a mention
The contacts menu was triggered only when the avatar or the name of the
user were clicked. Due to this, clicking on certain (small) areas of a
mention (like the right end, or the space between the avatar and the
name) did not show the contacts menu. Now the contacts menu is shown
when any area of the mention is clicked.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Fix position of contacts menu shown on mentions
There are no default CSS rules for the contacts menu, as its position
depends on the element on which it is shown. Note, however, that if no
explicit rules are provided the contacts menu on mentions is affected by
the rules for the contacts menu on shares from the sharing tab.

The contacts menu is now positioned to show the tip of the arrow
horizontally aligned with the center of the avatar, and with the top of
the menu slightly below the bottom border of the mention.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@MorrisJobke MorrisJobke added this to the Nextcloud 14.0.2 milestone Sep 24, 2018

@blizzz blizzz merged commit 1b493b7 into stable14 Sep 26, 2018

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@MorrisJobke MorrisJobke deleted the stable14-11258-fix-contacts-menu-on-mentions branch Oct 1, 2018

@MorrisJobke MorrisJobke referenced this pull request Oct 3, 2018

Merged

14.0.2 RC 1 #11588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment