Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Do not hide the progress bar while the chunked upload is being assembled #11399

Conversation

@danxuliu
Copy link
Member

@danxuliu danxuliu commented Sep 26, 2018

Backport of #11112

Large files are not uploaded in a single operation, but uploaded in
several chunks; once all the chunks are uploaded then the server needs
to assemble them to get the final file.

Before, once the chunks were uploaded the progress bar was hidden.
However, this was confusing for the users, as the file could still need
some time to appear in the file list due to the assembling. Now once all
the chunks are uploaded the text in the progress bar changes to inform
the user that there are still some pending operations, and only when the
file is finally assembled the progress bar is hidden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 5d84475 into stable14 Sep 27, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details
@MorrisJobke MorrisJobke deleted the stable14-11112-do-not-hide-the-progress-bar-while-the-chunked-upload-is-being-assembled branch Oct 1, 2018
@MorrisJobke MorrisJobke mentioned this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants