Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Fix "checkWellKnownUrl" not being run #11418

Merged

Conversation

Projects
None yet
3 participants
@danxuliu
Copy link
Member

danxuliu commented Sep 27, 2018

Backport of #11411

Fix "checkWellKnownUrl" not being run
The check is run only if its last parameter is true; data() tries to
convert the HTML attribute string to an actual JavaScript value, so
"true" is returned as an actual boolean instead of an string; as a
strict comparison against "true" was used the result was false and thus
the checks were not run.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>

@MorrisJobke MorrisJobke merged commit 3894e59 into stable14 Sep 28, 2018

0 of 2 checks passed

continuous-integration/drone/pr the build failed
Details
continuous-integration/drone/push the build failed
Details

@MorrisJobke MorrisJobke deleted the stable14-11411-fix-checkWellKnownUrl-not-being-executed branch Oct 1, 2018

@MorrisJobke MorrisJobke referenced this pull request Oct 3, 2018

Merged

14.0.2 RC 1 #11588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.