New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Fix a misleading setup check for .well-known/caldav & carddav #11738

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@MorrisJobke
Member

MorrisJobke commented Oct 10, 2018

The problem is that the version without the slash is the correct one.

Backport of #11733

Fix a misleading setup check for .well-known/caldav & carddav
The problem is that the version without the slash is the correct one.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Oct 11, 2018

Should we put it in 14.0.2?

Got more feedback in the forums: https://help.nextcloud.com/t/help-testing-rc1-version-of-14-0-2-13-0-7-and-12-0-12/38359/19?u=morrisjobke

I‘m fine with putting it in, because it is a really tiny change and only in a setup check.

cc @rullzer @blizzz @nickvergessen @danxuliu

@rullzer

This comment has been minimized.

Member

rullzer commented Oct 11, 2018

Fine by me

@MorrisJobke

This comment has been minimized.

Member

MorrisJobke commented Oct 11, 2018

Okay - let's get this into 14.0.2 to not confuse people.

@MorrisJobke MorrisJobke merged commit 5bf4bc7 into stable14 Oct 11, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the backport/11733/fix-setupcheck-14 branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment