Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[stable14] Fix a misleading setup check for .well-known/caldav & carddav #11738
Conversation
MorrisJobke
added
the
3. to review
label
Oct 10, 2018
MorrisJobke
added this to the Nextcloud 14.0.3 milestone
Oct 10, 2018
MorrisJobke
requested review from
rullzer,
ChristophWurst and
danxuliu
Oct 10, 2018
ChristophWurst
added
4. to release
and removed
3. to review
labels
Oct 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Should we put it in 14.0.2? Got more feedback in the forums: https://help.nextcloud.com/t/help-testing-rc1-version-of-14-0-2-13-0-7-and-12-0-12/38359/19?u=morrisjobke I‘m fine with putting it in, because it is a really tiny change and only in a setup check. |
This comment has been minimized.
This comment has been minimized.
|
Fine by me |
MorrisJobke
modified the milestones:
Nextcloud 14.0.3,
Nextcloud 14.0.2
Oct 11, 2018
This comment has been minimized.
This comment has been minimized.
|
Okay - let's get this into 14.0.2 to not confuse people. |
MorrisJobke
merged commit 5bf4bc7
into
stable14
Oct 11, 2018
1 check failed
continuous-integration/drone/pr
the build failed
Details
MorrisJobke
deleted the
backport/11733/fix-setupcheck-14
branch
Oct 11, 2018
This was referenced Oct 11, 2018
Merged
rigrig
referenced this pull request
Oct 11, 2018
Closed
Setup check for .well-known/caldav & carddav broken on Firefox #11773
timm2k
referenced this pull request
Oct 12, 2018
Closed
[13-0.7 & 14.0.2] /.well-known/caldav and carddav #11787
nextcloud-bot
referenced this pull request
Oct 12, 2018
Closed
/.well-known/caldav and /.well-known/carddav not resolved on port <> 80 #11789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
MorrisJobke commentedOct 10, 2018
The problem is that the version without the slash is the correct one.
Backport of #11733