New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] Users page lazy multiselect group dropdowns #1175

Merged
merged 1 commit into from Aug 30, 2016

Conversation

Projects
None yet
5 participants
@blizzz
Member

blizzz commented Aug 29, 2016

Backport of Users page lazy multiselect group dropdowns #1128 to stable9
Users page lazy multiselect group dropdowns

Instead of pre-rendering all multiselects with lots of group entries,
the current groups are now displayed as simple labels.
Behind the labels there is a pencil icon like for other fields.
When clicking the pencil icon, the dropdown will be spawned and will
open itself.
Upon closing of the dropdown, the label comes back with the updated
selection and the dropdown is destroyed.

Extra non-available groups also in list

Fix group sorting in user list group selection
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 29, 2016

@blizzz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ringmaster, @icewind1991 and @tanghus to be potential reviewers

mention-bot commented Aug 29, 2016

@blizzz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ringmaster, @icewind1991 and @tanghus to be potential reviewers

@MorrisJobke

This comment has been minimized.

Show comment
Hide comment
@MorrisJobke

MorrisJobke Aug 30, 2016

Member

Tested and works 👍

Member

MorrisJobke commented Aug 30, 2016

Tested and works 👍

@rullzer

This comment has been minimized.

Show comment
Hide comment
@rullzer

rullzer Aug 30, 2016

Member

👍

Member

rullzer commented Aug 30, 2016

👍

@rullzer rullzer merged commit d2a96a6 into stable9 Aug 30, 2016

4 checks passed

Scrutinizer 13 new issues
Details
approvals/lgtm this commit looks good
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rullzer rullzer deleted the backport-1128-stable9 branch Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment