Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Ignore "session_lifetime" if it can not be converted to a number #11761

Conversation

@danxuliu
Copy link
Member

@danxuliu danxuliu commented Oct 11, 2018

Backport of #11756

When "session_lifetime" can not be converted to a number the interval
becomes a NaN due to dividing it by 2. This NaN was "dragged" over all
the other mathematical operations and caused the csrftoken to be got
again and again due to an infinite loop with no pauses in "setInterval".
Now, the interval is set to the default value instead if the
"session_lifetime" can not be converted to a number.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@rullzer rullzer added 4. to release and removed 3. to review labels Oct 11, 2018
@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 11, 2018

CI just ran into timeouts due to load.

@MorrisJobke MorrisJobke merged commit feb8a79 into stable14 Oct 11, 2018
1 check failed
1 check failed
continuous-integration/drone/pr the build failed
Details
@MorrisJobke MorrisJobke deleted the stable14-11756-ignore-session-lifetime-if-it-can-not-be-converted-to-a-number branch Oct 11, 2018
@rullzer rullzer mentioned this pull request Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.