/server

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Ignore "session_lifetime" if it can not be converted to a number #11761

Merged
merged 1 commit into from Oct 11, 2018
+3 −1

Conversation

Reviewers

@nickvergessen nickvergessen

@MorrisJobke MorrisJobke

@rullzer rullzer

@ChristophWurst ChristophWurst

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  Nextcloud 14.0.3
4 participants
@danxuliu @MorrisJobke @nickvergessen @rullzer
@danxuliu
Member

danxuliu commented Oct 11, 2018

Backport of #11756
@danxuliu
Ignore "session_lifetime" if it can not be converted to a number 
When "session_lifetime" can not be converted to a number the interval
becomes a NaN due to dividing it by 2. This NaN was "dragged" over all
the other mathematical operations and caused the csrftoken to be got
again and again due to an infinite loop with no pauses in "setInterval".
Now, the interval is set to the default value instead if the
"session_lifetime" can not be converted to a number.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
a246cc1

@danxuliu danxuliu added bug 3. to review labels Oct 11, 2018

@danxuliu danxuliu added this to the Nextcloud 14.0.3 milestone Oct 11, 2018

@danxuliu danxuliu requested review from rullzer, MorrisJobke and ChristophWurst Oct 11, 2018

@rullzer rullzer added 4. to release and removed 3. to review labels Oct 11, 2018

@MorrisJobke

This comment has been minimized.

Sign in to view
Member

MorrisJobke commented Oct 11, 2018

CI just ran into timeouts due to load.

@MorrisJobke MorrisJobke merged commit feb8a79 into stable14 Oct 11, 2018
1 check failed

1 check failed

continuous-integration/drone/pr the build failed
Details

@MorrisJobke MorrisJobke deleted the stable14-11756-ignore-session-lifetime-if-it-can-not-be-converted-to-a-number branch Oct 11, 2018

@rullzer rullzer referenced this pull request Oct 12, 2018

Merged

14.0.3 #11784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment