New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable14] Fix a case where "password_by_talk" was not a boolean #11851

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
4 participants
@MorrisJobke
Member

MorrisJobke commented Oct 15, 2018

(e.g. null or "0") and actively cast it to a boolean

This was the error message that we have seen:

Argument 1 passed to OC\\Share20\\Share::setSendPasswordByTalk() must be of the type boolean, null given, called in apps/sharebymail/lib/ShareByMailProvider.php on line 981

Backport of #11802

Fix a case where "password_by_talk" was not a boolean (e.g. null or "…
…0") and actively cast it to a boolean

This was the error message that we have seen:

```
Argument 1 passed to OC\\Share20\\Share::setSendPasswordByTalk() must be of the type boolean, null given, called in apps/sharebymail/lib/ShareByMailProvider.php on line 981
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

@MorrisJobke MorrisJobke added this to the Nextcloud 14.0.4 milestone Oct 15, 2018

@MorrisJobke MorrisJobke changed the title from Fix a case where "password_by_talk" was not a boolean to [stable14] Fix a case where "password_by_talk" was not a boolean Oct 15, 2018

@blizzz

blizzz approved these changes Oct 16, 2018

@nickvergessen nickvergessen merged commit c1fbf70 into stable14 Oct 16, 2018

1 check failed

continuous-integration/drone/pr the build failed
Details

@nickvergessen nickvergessen deleted the backport/11802/fix-password_by_talk-not-a-boolean branch Oct 16, 2018

@MorrisJobke MorrisJobke referenced this pull request Nov 13, 2018

Merged

14.0.4 RC 1 #12436

@MorrisJobke MorrisJobke referenced this pull request Nov 22, 2018

Merged

14.0.4 #12586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment